Repository navigation
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The API key expiration changes have no active review issues.
No open issues 🎉
What changed in this PR
Adds API key expiration management to the Python client’s DB user APIs for licensed Weaviate 1.41+ servers.
Changes:
- Supports expiration during user creation and setting or removing expiration for existing users.
- Exposes expiration timestamps in user responses and updates synchronous and asynchronous type signatures.
- Adds integration coverage and configures CI to test against Weaviate 1.41 with optional license credentials.
| File | Description |
|---|---|
weaviate/util.py |
Adds the Weaviate 1.41 version guard. |
weaviate/users/users.py |
Adds expiration fields to user models. |
weaviate/users/sync.pyi |
Updates synchronous API signatures for expiration support. |
weaviate/users/base.py |
Implements expiration requests, response parsing, and related documentation. |
weaviate/users/async_.pyi |
Updates asynchronous API signatures for expiration support. |
weaviate/rbac/models.py |
Types the expiration field in DB user responses. |
integration/test_users.py |
Tests expiration management, key rotation, and unsupported versions. |
ci/docker-compose-rbac.yml |
Passes the optional license key to the RBAC server. |
.github/workflows/main.yaml |
Adds Weaviate 1.41 to integration testing and supplies license credentials. |
Review effort: Balanced
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2249 +/- ##
==========================================
- Coverage 89.23% 89.03% -0.21%
==========================================
Files 312 312
Lines 24715 24824 +109
==========================================
+ Hits 22055 22102 +47
- Misses 2660 2722 +62 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.