Repository navigation
chore(deps): bump the cargo group across 1 directory with 2 updates - #1072
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps the cargo group with 2 updates in the / directory: [time](https://github.com/time-rs/time) and [zip](https://github.com/zip-rs/zip2). Updates `time` from 0.3.44 to 0.3.47 - [Release notes](https://github.com/time-rs/time/releases) - [Changelog](https://github.com/time-rs/time/blob/main/CHANGELOG.md) - [Commits](time-rs/time@v0.3.44...v0.3.47) Updates `zip` from 8.6.0 to 9.2.2 - [Release notes](https://github.com/zip-rs/zip2/releases) - [Changelog](https://github.com/zip-rs/zip2/blob/master/CHANGELOG.md) - [Commits](zip-rs/zip2@v8.6.0...v9.2.2) --- updated-dependencies: - dependency-name: time dependency-version: 0.3.47 dependency-type: indirect dependency-group: cargo - dependency-name: zip dependency-version: 9.2.2 dependency-type: direct:production dependency-group: cargo ... Signed-off-by: dependabot[bot] <support@github.com>
|
@dependabot recreate |
There was a problem hiding this comment.
Reviewed commit c326f6b057b53101eec39ec727577d0d06477dbd. There are two independent build blockers to resolve before merging this security update.
1. Reconcile the exact time requirement and lockfile
tools/Cargo.toml:17 requires time = "=0.3.55", but the committed Cargo.lock resolves time 0.3.47. The PR description also advertises 0.3.47. This exact requirement cannot be satisfied by the committed lockfile.
Read-only reproduction from this PR checkout:
python3 - <<'PY'
import pathlib, tomllib
manifest = tomllib.loads(pathlib.Path("tools/Cargo.toml").read_text())
lock = tomllib.loads(pathlib.Path("Cargo.lock").read_text())
print("requirement:", manifest["dependencies"]["time"]["version"])
print("locked:", [p["version"] for p in lock["package"] if p["name"] == "time"])
PYObserved: requirement: =0.3.55 and locked: ['0.3.47'].
Choose the intended patched version deliberately, make the manifest/lockfile/description agree, and verify locked resolution with the pinned Rust 1.89 toolchain. There is no need to upgrade Rust or change the installer/release pins.
2. Adapt the SDK reader to zip 9's fallible filename API
The version bump leaves tools/src/sdk.rs:288,292 calling Path::new(entry.name()). With zip 9.2.2, name() returns ZipResult<Cow<'_, str>>, rather than &str.
I reproduced the API error with Rust 1.89 using this independent compile-only probe (no archive is executed or extracted):
[package]
name = "zip-api-probe"
version = "0.0.0"
edition = "2021"
[dependencies]
zip = { version = "=9.2.2", default-features = false, features = ["deflate-flate2"] }
flate2 = { version = "=1.1.10", default-features = false, features = ["rust_backend"] }use std::{fs::File, path::Path};
fn main() -> Result<(), Box<dyn std::error::Error>> {
let mut archive = zip::ZipArchive::new(File::open("unused.zip")?)?;
let entry = archive.by_index(0)?;
let _ = Path::new(entry.name());
Ok(())
}cargo +1.89.0 check --jobs 2 produces E0308: expected a reference, found Result<Cow<'_, str>, ZipError>.
Handle filename decoding errors and borrow the decoded name for the existing strict path checks. Preserve duplicate/link/containment/size checks; do not replace rejection with a sanitizing filename API.
Validation requested
After both corrections, run cargo +1.89.0 check --locked --jobs 2 -p wave-tools --all-targets, the tooling tests, and focused ZIP creation/extraction regressions including unsafe names and decoding failures. The probe above confirms the API incompatibility; it is not a claim that the complete updated tooling suite has been run successfully.
Recheck — 2026-11-04
The PR is still at the exact reviewed head c326f6b. Re-reading the committed manifest/lock confirms the =0.3.55 vs0.3.47 mismatch; the SDK filename API call sites are unchanged. Both build blockers above remain. This is a recheck of the same source, not another successful tooling build.
| getrandom = "=0.4.3" | ||
| yaml-rust2 = { version = "=0.13.0", default-features = false } | ||
| time = { version = "=0.3.44", features = ["formatting", "parsing"] } | ||
| time = { version = "=0.3.55", features = ["formatting", "parsing"] } |
There was a problem hiding this comment.
[P1] The exact time = "=0.3.55" requirement disagrees with the committed lockfile's time 0.3.47 and the PR description. Please select the intended patched version, regenerate the lockfile accordingly, and validate with Rust 1.89 and --locked. The review body includes a read-only manifest/lock reproduction.
| tar = { version = "=0.4.46", default-features = false } | ||
| flate2 = { version = "=1.1.10", default-features = false, features = ["rust_backend"] } | ||
| zip = { version = "=8.6.0", default-features = false, features = ["deflate-flate2"] } | ||
| zip = { version = "=9.2.2", default-features = false, features = ["deflate-flate2"] } |
There was a problem hiding this comment.
[P1] This major update also needs SDK call-site adaptation. In unchanged tools/src/sdk.rs, Path::new(entry.name()) no longer type-checks because zip 9.2.2 returns ZipResult<Cow<'_, str>> from name(). The matching-feature compile probe in the review reproduces E0308. Propagate decoding failures and borrow the decoded name while preserving the strict extraction checks.
|
Remaining changes before merge — reviewed head Please address both remaining build blockers:
Validation after the corrections: cargo +1.89.0 check --locked --jobs 2 -p wave-tools --all-targets
cargo +1.89.0 test --locked --jobs 2 -p wave-tools --test sdk --test artifactsInclude unsafe-name/decoding-failure and ZIP creation/extraction coverage. The SDK Rust call sites need a companion adaptation; a dependency manifest update alone does not fix the API mismatch. Detailed findings and reproduction: review. |
|
Superseded by #1090. |
Bumps the cargo group with 2 updates in the / directory: time and zip.
Updates
timefrom 0.3.44 to 0.3.47Release notes
Sourced from time's releases.
Changelog
Sourced from time's changelog.
... (truncated)
Commits
d5144cdv0.3.47 releasef6206b0Guard against integer overflow in release mode1c63dc7Avoid denial of service when parsing Rfc28225940df6Add builder methods to avoid verbose construction00881a4Manually format macros everywherebb723b6Addtrailing_inputmodifier toend31c4f8ePermitW12indate!macro490a17bMark error paths in well-known formats as cold6cb1896OptimizeRfc2822parsing6d264d5Remove erroneous#[inline(never)]attributesUpdates
zipfrom 8.6.0 to 9.2.2Release notes
Sourced from zip's releases.
... (truncated)
Changelog
Sourced from zip's changelog.
... (truncated)
Commits
1b431f6chore: Release 9.2.2 (#1250)39930cbci: add security permissions to style_and_docs.yml for SARIF upload (#1249)fa01d52ci: remove job-level concurrency group from release-plz.yml (#1248)1139473ci: [StepSecurity] Apply security best practices (workflow-level permissions ...eedfbfdci: Remove redundant cache; consolidate style_and_docs into 3 jobs; configure...3dd37e9ci: Prevent CI Complete from reaching Skipped state, which is considered pass...c735d50Merge commit from fork28414f5Merge commit from forkcfc056cci: Run unit tests in fuzz packages (#1244)1a1d362ci: Enable running style_and_docs separately, to clear outdated Clippy scan r...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsYou can disable automated security fix PRs for this repo from the Security Alerts page.