Skip to content

chore(deps): bump the cargo group across 1 directory with 2 updates - #1072

Closed
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/cargo/tools/cargo-e1e52bea82
Closed

dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/cargo/tools/cargo-e1e52bea82

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 2, 2026 •

Copy link
Copy Markdown

Bumps the cargo group with 2 updates in the / directory: time and zip.

Updates time from 0.3.44 to 0.3.47

Release notes

Sourced from time's releases.

v0.3.47

See the changelog for details.

v0.3.46

See the changelog for details.

v0.3.45

See the changelog for details.

Changelog

Sourced from time's changelog.

0.3.47 [2026-02-05]

Security

  • The possibility of a stack exhaustion denial of service attack when parsing RFC 2822 has been eliminated. Previously, it was possible to craft input that would cause unbounded recursion. Now, the depth of the recursion is tracked, causing an error to be returned if it exceeds a reasonable limit.

    This attack vector requires parsing user-provided input, with any type, using the RFC 2822 format.

Compatibility

  • Attempting to format a value with a well-known format (i.e. RFC 3339, RFC 2822, or ISO 8601) will error at compile time if the type being formatted does not provide sufficient information. This would previously fail at runtime. Similarly, attempting to format a value with ISO 8601 that is only configured for parsing (i.e. Iso8601::PARSING) will error at compile time.

Added

  • Builder methods for format description modifiers, eliminating the need for verbose initialization when done manually.
  • date!(2026-W01-2) is now supported. Previously, a space was required between W and 01.
  • [end] now has a trailing_input modifier which can either be prohibit (the default) or discard. When it is discard, all remaining input is ignored. Note that if there are components after [end], they will still attempt to be parsed, likely resulting in an error.

Changed

  • More performance gains when parsing.

Fixed

  • If manually formatting a value, the number of bytes written was one short for some components. This has been fixed such that the number of bytes written is always correct.
  • The possibility of integer overflow when parsing an owned format description has been effectively eliminated. This would previously wrap when overflow checks were disabled. Instead of storing the depth as u8, it is stored as u32. This would require multiple gigabytes of nested input to overflow, at which point we've got other problems and trivial mitigations are available by downstream users.

0.3.46 [2026-01-23]

Added

  • All possible panics are now documented for the relevant methods.
  • The need to use #[serde(default)] when using custom serde formats is documented. This applies only when deserializing an Option<T>.
  • Duration::nanoseconds_i128 has been made public, mirroring std::time::Duration::from_nanos_u128.

... (truncated)

Commits
  • d5144cd v0.3.47 release
  • f6206b0 Guard against integer overflow in release mode
  • 1c63dc7 Avoid denial of service when parsing Rfc2822
  • 5940df6 Add builder methods to avoid verbose construction
  • 00881a4 Manually format macros everywhere
  • bb723b6 Add trailing_input modifier to end
  • 31c4f8e Permit W12 in date! macro
  • 490a17b Mark error paths in well-known formats as cold
  • 6cb1896 Optimize Rfc2822 parsing
  • 6d264d5 Remove erroneous #[inline(never)] attributes
  • Additional commits viewable in compare view

Updates zip from 8.6.0 to 9.2.2

Release notes

Sourced from zip's releases.

v9.2.2

🚜 Refactor

  • Eliminate the use of SwitchWriterFunction (a Box<dyn FnOnce<_>>) (#1235)

⚙️ Miscellaneous Tasks

  • Fix build error (can't convert getrandom::Error to io::Error without getrandom/std) (#1240)

v9.2.1

🚜 Refactor

  • Eliminate the use of SwitchWriterFunction (a Box<dyn FnOnce<_>>) (#1235)

⚙️ Miscellaneous Tasks

  • Fix build error (can't convert getrandom::Error to io::Error without getrandom/std) (#1240)

v9.2.0

🚀 Features

  • (write) add parallel compression and batch appending for ZipWriter with Rayon (#1225)
  • add index_for_name_raw (#1210)
  • (extract) multi-threaded parallel extraction engine and safe extent pre-allocation (#1207)
  • (read) add index-free iterable ZIP reader (#1218)

🐛 Bug Fixes

  • by_name().get_metadata() and by_index().get_metadata() now succeed even when compression method is unsupported (#1228)
  • (read) keep ZipIterable::len at the central directory entry count (#1221)
  • (fuzz) count reopens in copy bases when tracking comment shrink (#1222)

⚡ Performance

  • (read) eliminate redundant pre-scan I/O and atomic contention in par_extract (#1227)
  • (read) eliminate redundant clone and heap allocations in safe_prepare_path (#1224)

v9.1.3

🚀 Features

  • (extra_fields) support 0xd935 Android ZIP alignment extra field (#928) (#1198)

🐛 Bug Fixes

  • (format) record correct 32-bit EOCD offset in ZIP64 archives (#1205)
  • (aes) wipe AES round keys when the cipher is dropped (#1204)
  • (fuzz) treat a comment change in a merged sub-writer as non-streamable (#1188)
  • (aes) zeroize AesCtrZipKeyStream buffer and counter on drop (#1196)
  • (extract) prevent symlink-follow truncation via FILE_FLAG_OPEN_REPARSE_POINT (#1195)
  • (write) drop a stale Unicode Path extra field when copying an entry (#1187)

... (truncated)

Changelog

Sourced from zip's changelog.

9.2.2 - 2026-11-01

🚜 Refactor

  • Eliminate the use of SwitchWriterFunction (a Box<dyn FnOnce<_>>) (#1235)

⚙️ Miscellaneous Tasks

  • Fix build error (can't convert getrandom::Error to io::Error without getrandom/std) (#1240)

9.2.0 - 2026-10-31

🚀 Features

  • (write) add parallel compression and batch appending for ZipWriter with Rayon (#1225)
  • add index_for_name_raw (#1210)
  • (extract) multi-threaded parallel extraction engine and safe extent pre-allocation (#1207)
  • (read) add index-free iterable ZIP reader (#1218)

🐛 Bug Fixes

  • by_name().get_metadata() and by_index().get_metadata() now succeed even when compression method is unsupported (#1228)
  • (read) keep ZipIterable::len at the central directory entry count (#1221)
  • (fuzz) count reopens in copy bases when tracking comment shrink (#1222)

⚡ Performance

  • (read) eliminate redundant pre-scan I/O and atomic contention in par_extract (#1227)
  • (read) eliminate redundant clone and heap allocations in safe_prepare_path (#1224)

9.1.3 - 2026-10-27

🚀 Features

  • (extra_fields) support 0xd935 Android ZIP alignment extra field (#928) (#1198)

🐛 Bug Fixes

  • (format) record correct 32-bit EOCD offset in ZIP64 archives (#1205)
  • (aes) wipe AES round keys when the cipher is dropped (#1204)
  • (fuzz) treat a comment change in a merged sub-writer as non-streamable (#1188)
  • (aes) zeroize AesCtrZipKeyStream buffer and counter on drop (#1196)
  • (extract) prevent symlink-follow truncation via FILE_FLAG_OPEN_REPARSE_POINT (#1195)
  • (write) drop a stale Unicode Path extra field when copying an entry (#1187)
  • (write) don't leave a stale tail that completes a fake EOCD in the comment (#1186)
  • (write) reject deflate levels below 10 when only zopfli is enabled (#1182)

⚡ Performance

  • (read) accelerate extraction with 64 KiB reusable buffer (#1206)

... (truncated)

Commits
  • 1b431f6 chore: Release 9.2.2 (#1250)
  • 39930cb ci: add security permissions to style_and_docs.yml for SARIF upload (#1249)
  • fa01d52 ci: remove job-level concurrency group from release-plz.yml (#1248)
  • 1139473 ci: [StepSecurity] Apply security best practices (workflow-level permissions ...
  • eedfbfd ci: Remove redundant cache; consolidate style_and_docs into 3 jobs; configure...
  • 3dd37e9 ci: Prevent CI Complete from reaching Skipped state, which is considered pass...
  • c735d50 Merge commit from fork
  • 28414f5 Merge commit from fork
  • cfc056c ci: Run unit tests in fuzz packages (#1244)
  • 1a1d362 ci: Enable running style_and_docs separately, to clear outdated Clippy scan r...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps the cargo group with 2 updates in the / directory: [time](https://github.com/time-rs/time) and [zip](https://github.com/zip-rs/zip2).


Updates `time` from 0.3.44 to 0.3.47
- [Release notes](https://github.com/time-rs/time/releases)
- [Changelog](https://github.com/time-rs/time/blob/main/CHANGELOG.md)
- [Commits](time-rs/time@v0.3.44...v0.3.47)

Updates `zip` from 8.6.0 to 9.2.2
- [Release notes](https://github.com/zip-rs/zip2/releases)
- [Changelog](https://github.com/zip-rs/zip2/blob/master/CHANGELOG.md)
- [Commits](zip-rs/zip2@v8.6.0...v9.2.2)

---
updated-dependencies:
- dependency-name: time
  dependency-version: 0.3.47
  dependency-type: indirect
  dependency-group: cargo
- dependency-name: zip
  dependency-version: 9.2.2
  dependency-type: direct:production
  dependency-group: cargo
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file rust Pull requests that update rust code labels Nov 2, 2026
@LunaStev

LunaStev commented Nov 2, 2026

Copy link
Copy Markdown
Member

@dependabot recreate

@LunaStev LunaStev left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed commit c326f6b057b53101eec39ec727577d0d06477dbd. There are two independent build blockers to resolve before merging this security update.

1. Reconcile the exact time requirement and lockfile

tools/Cargo.toml:17 requires time = "=0.3.55", but the committed Cargo.lock resolves time 0.3.47. The PR description also advertises 0.3.47. This exact requirement cannot be satisfied by the committed lockfile.

Read-only reproduction from this PR checkout:

python3 - <<'PY'
import pathlib, tomllib
manifest = tomllib.loads(pathlib.Path("tools/Cargo.toml").read_text())
lock = tomllib.loads(pathlib.Path("Cargo.lock").read_text())
print("requirement:", manifest["dependencies"]["time"]["version"])
print("locked:", [p["version"] for p in lock["package"] if p["name"] == "time"])
PY

Observed: requirement: =0.3.55 and locked: ['0.3.47'].

Choose the intended patched version deliberately, make the manifest/lockfile/description agree, and verify locked resolution with the pinned Rust 1.89 toolchain. There is no need to upgrade Rust or change the installer/release pins.

2. Adapt the SDK reader to zip 9's fallible filename API

The version bump leaves tools/src/sdk.rs:288,292 calling Path::new(entry.name()). With zip 9.2.2, name() returns ZipResult<Cow<'_, str>>, rather than &str.

I reproduced the API error with Rust 1.89 using this independent compile-only probe (no archive is executed or extracted):

[package]
name = "zip-api-probe"
version = "0.0.0"
edition = "2021"

[dependencies]
zip = { version = "=9.2.2", default-features = false, features = ["deflate-flate2"] }
flate2 = { version = "=1.1.10", default-features = false, features = ["rust_backend"] }
use std::{fs::File, path::Path};

fn main() -> Result<(), Box<dyn std::error::Error>> {
    let mut archive = zip::ZipArchive::new(File::open("unused.zip")?)?;
    let entry = archive.by_index(0)?;
    let _ = Path::new(entry.name());
    Ok(())
}

cargo +1.89.0 check --jobs 2 produces E0308: expected a reference, found Result<Cow<'_, str>, ZipError>.

Handle filename decoding errors and borrow the decoded name for the existing strict path checks. Preserve duplicate/link/containment/size checks; do not replace rejection with a sanitizing filename API.

Validation requested

After both corrections, run cargo +1.89.0 check --locked --jobs 2 -p wave-tools --all-targets, the tooling tests, and focused ZIP creation/extraction regressions including unsafe names and decoding failures. The probe above confirms the API incompatibility; it is not a claim that the complete updated tooling suite has been run successfully.

Recheck — 2026-11-04

The PR is still at the exact reviewed head c326f6b. Re-reading the committed manifest/lock confirms the =0.3.55 vs0.3.47 mismatch; the SDK filename API call sites are unchanged. Both build blockers above remain. This is a recheck of the same source, not another successful tooling build.

Comment thread tools/Cargo.toml
getrandom = "=0.4.3"
yaml-rust2 = { version = "=0.13.0", default-features = false }
time = { version = "=0.3.44", features = ["formatting", "parsing"] }
time = { version = "=0.3.55", features = ["formatting", "parsing"] }

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] The exact time = "=0.3.55" requirement disagrees with the committed lockfile's time 0.3.47 and the PR description. Please select the intended patched version, regenerate the lockfile accordingly, and validate with Rust 1.89 and --locked. The review body includes a read-only manifest/lock reproduction.

Comment thread tools/Cargo.toml
tar = { version = "=0.4.46", default-features = false }
flate2 = { version = "=1.1.10", default-features = false, features = ["rust_backend"] }
zip = { version = "=8.6.0", default-features = false, features = ["deflate-flate2"] }
zip = { version = "=9.2.2", default-features = false, features = ["deflate-flate2"] }

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] This major update also needs SDK call-site adaptation. In unchanged tools/src/sdk.rs, Path::new(entry.name()) no longer type-checks because zip 9.2.2 returns ZipResult<Cow<'_, str>> from name(). The matching-feature compile probe in the review reproduces E0308. Propagate decoding failures and borrow the decoded name while preserving the strict extraction checks.

@LunaStev

LunaStev commented Nov 5, 2026

Copy link
Copy Markdown
Member

Remaining changes before merge — reviewed head c326f6b057b53101eec39ec727577d0d06477dbd.

Please address both remaining build blockers:

  1. Align the intended patched time version across tools/Cargo.toml and Cargo.lock. The manifest requires =0.3.55 while the lockfile contains 0.3.47. Regenerate a consistent locked resolution using the pinned Rust 1.89.0 toolchain.
  2. Adapt tools/src/sdk.rs to zip 9's fallible filename API. entry.name() now returns Result<Cow,ZipError>; decode/validate it and borrow the resulting name for path checks. Keep containment, duplicate, link and size rejection intact.

Validation after the corrections:

cargo +1.89.0 check --locked --jobs 2 -p wave-tools --all-targets
cargo +1.89.0 test --locked --jobs 2 -p wave-tools --test sdk --test artifacts

Include unsafe-name/decoding-failure and ZIP creation/extraction coverage. The SDK Rust call sites need a companion adaptation; a dependency manifest update alone does not fix the API mismatch.

Detailed findings and reproduction: review.

@dependabot @github

dependabot Bot commented on behalf of github Nov 12, 2026

Copy link
Copy Markdown
Author

Superseded by #1090.

@dependabot dependabot Bot closed this Nov 12, 2026
@dependabot
dependabot Bot deleted the dependabot/cargo/tools/cargo-e1e52bea82 branch November 12, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant