Repository navigation
Upgrade to zig 0.17.0 - #215
Merged
Merged
Conversation
use translate-c to interface with sqlite c library
std.Build.addTranslateC is deprecated in Zig 0.17 and goes away in 0.18; the translate-c package (branch zig-0.17.x) is its replacement. Its struct fields are not default-initialised unless asked, so default_init keeps struct literals such as vtab.zig's sqlite3_module compiling against SQLite versions that add fields (xIntegrity in 3.44).
Zig 0.17: translate the C API with the translate-c package; CI on 0.17.0
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used translate-c in the build script to interface with the sqlite c library because the @cImport is gone in zig 0.17.0.
The preprocess-headers step also had to change a bit functionally. I fixed a bug where the file writers would not actually write the results of the preprocessing into the file and not flush the file writers. I ran these steps and c/loadable-ext-sqlite3.h and c/loadable-ext-sqlite3ext.h do need some updating, but I'll keep that out of this PR, which shall focus purely on the zig version upgrade.
No other functional changes were made to the code.