Repository navigation
feat(web): what people say, five public quotes about knobs - #103
Merged
Merged
Conversation
Collaborator
Author
|
Lighthouse on live https://knobs.dev/ after deploy (PageSpeed Insights, second run): mobile 100/100/100/100, agentic browsing 100, CLS 0.001, LCP 1.1 s; desktop all 100, CLS 0, LCP 0.3 s. The first run gave mobile performance 95 (PSI moves a few points between runs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proof
Local dev server (https://knobs.localhost), ego browser, 1440 px and 390 px, light and dark. No horizontal overflow, all five avatars load (96 px webp, 48 CSS px, width and height set, lazy).
llms-full.txt, before and after the separator fix (only these five lines change in the whole file):
Checks:
pnpm --filter @knobs/web test71/71 (3 new converter tests), typecheck, lint, format:check and build (dev-tools-check, docs-check, head-check) pass. code-reviewer: 2 rounds, clean.Lighthouse: run on the live page after deploy, results in a comment.
Each quote was checked against its public source (link, date, author bio) before the build. Mehmet Aydın Baytaş's X bio says "creative director @_momenthq"; justin levine's says "eng @mastra".
Risk
Tier: low. Area: landing page UI and the llms text converter.
How to revert
Revert the merge commit. The deploy runs again on main.
Test plan