Skip to content

Name the own project in the origin of OIDC clients - #595

Open
luismeyer wants to merge 1 commit into
mainfrom
luismeyer/oidc-origin-project-id
Open

luismeyer wants to merge 1 commit into
mainfrom
luismeyer/oidc-origin-project-id

Conversation

@luismeyer

Copy link
Copy Markdown
Member

Why

  • A client that authenticates with OIDC reported origin: { provider: 'vercel' }, with no projectId. Only createClient({ projectId }) for a connected project set one.
  • getProviderData from flags/next and flags/sveltekit passes the origin through unchanged, so a discovery endpoint built with it could not say which project a Vercel Flags flag belongs to. getProviderData from @flags-sdk/vercel was unaffected because it resolves the project itself.
  • Vercel uses that projectId to attribute a deployment's code references to the project, for example to mark a flag as seen in production. Without it the flag is never marked.

What

  • The origin of an OIDC client now names the deployment's own project when VERCEL_PROJECT_ID is set. Clients with an SDK key are unchanged.
  • getProviderData from @flags-sdk/vercel now skips its datafile lookup for these origins, since the origin already names the project.

Validation

  • Observed on a preview deployment of an OIDC-only project using getProviderData from flags/next: the flag was stored with origin: { provider: 'vercel' }.
  • Not covered: projects that do not expose system environment variables have no VERCEL_PROJECT_ID, so their origin stays as before. vercel/api handles that case on its side (companion PR).

🤖 Generated with Claude Code

Co-Authored-By: Claude Code <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
flags-playground Ready Ready Preview, v0 Nov 10, 2026 3:51pm UTC
flags-sdk-dev Ready Ready Preview, v0 Nov 10, 2026 3:51pm UTC
flags-sdk-flagsmith Ready Ready Preview, v0 Nov 10, 2026 3:51pm UTC
flags-sdk-growthbook Ready Ready Preview, v0 Nov 10, 2026 3:51pm UTC
flags-sdk-launchdarkly Ready Ready Preview, v0 Nov 10, 2026 3:51pm UTC
flags-sdk-openfeature Ready Ready Preview, v0 Nov 10, 2026 3:51pm UTC
flags-sdk-posthog Ready Ready Preview, v0 Nov 10, 2026 3:51pm UTC
flags-sdk-reflag Ready Ready Preview, v0 Nov 10, 2026 3:51pm UTC
flags-sdk-snippets Ready Ready Preview, v0 Nov 10, 2026 3:51pm UTC
flags-sdk-statsig Ready Ready Preview, v0 Nov 10, 2026 3:51pm UTC
flags-sdk-sveltekit-snippets Ready Ready Preview, v0 Nov 10, 2026 3:51pm UTC
shirt-shop Ready Ready Preview, v0 Nov 10, 2026 3:51pm UTC
shirt-shop-api Ready Ready Preview, v0 Nov 10, 2026 3:51pm UTC

This branch was successfully deployed

14 active deployments
Preview – flags-sdk-dev — 4b291155 Deployed Nov 10, 2026 by vercel[bot]
Preview – flags-sdk-sveltekit-snippets — 4b291155 Deployed Nov 10, 2026 by vercel[bot]
Preview – flags-sdk-snippets — 4b291155 Deployed Nov 10, 2026 by vercel[bot]
Preview – flags-sdk-vercel — 4b291155 Deployed Nov 10, 2026 by vercel[bot]
Preview – flags-sdk-posthog — 4b291155 Deployed Nov 10, 2026 by vercel[bot]
Preview – shirt-shop — 4b291155 Deployed Nov 10, 2026 by vercel[bot]
Preview – flags-sdk-statsig — 4b291155 Deployed Nov 10, 2026 by vercel[bot]
Preview – flags-sdk-launchdarkly — 4b291155 Deployed Nov 10, 2026 by vercel[bot]
Preview – flags-playground — 4b291155 Deployed Nov 10, 2026 by vercel[bot]
Preview – flags-sdk-reflag — 4b291155 Deployed Nov 10, 2026 by vercel[bot]
Preview – flags-sdk-growthbook — 4b291155 Deployed Nov 10, 2026 by vercel[bot]
Preview – flags-sdk-flagsmith — 4b291155 Deployed Nov 10, 2026 by vercel[bot]
Preview – flags-sdk-openfeature — 4b291155 Deployed Nov 10, 2026 by vercel[bot]
Preview – shirt-shop-api — 4b291155 Deployed Nov 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant