Skip to content

DRA-5759 Remove Ember Octane note from PR template #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OwenCoogan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

DRA-5759 Remove Ember Octane note from PR template #301

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
088aaf9
Remove Developer Heads Up section from PR template
OwenCoogan Nov 10, 2026
0ee73aa
Remove Glimmer migration item from PR checklist
OwenCoogan Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,6 @@ Related to : #<!-- enter issue number here -->
<!-- Bug: a given issue trail on sentry should stop happening -->
<!-- Feature: Implements X thrift service / Z HTTP REST API added, provide instructions on how leverage your feature from staging or your workstation -->

### 🧑‍💻 Developer Heads Up

⚡ Since we are using [Ember Octane](https://blog.emberjs.com/octane-is-here/) now:

- Feel free to migrate existing components to Glimmer Components.
- Write new ones exclusively in it.

Useful Resource : [Ember Octane vs Classic Cheat Sheet](https://ember-learn.github.io/ember-octane-vs-classic-cheat-sheet/)

### Good PR checklist

- [ ] Title makes sense
Expand All @@ -30,7 +21,6 @@ Useful Resource : [Ember Octane vs Classic Cheat Sheet](https://ember-learn.gith
- [ ] Properly assigned
- [ ] Added/updated tests
- [ ] Added/updated documentation
- [ ] Migrated touched components to Glimmer Components
- [ ] Properly labeled

### Additional Notes
Expand Down
Loading