Repository navigation
fix(runway): validate GitHub merger config durations and hosts Copy title - #874
Closed
DivyanshGarg380 wants to merge 2 commits into
Closed
DivyanshGarg380 wants to merge 2 commits into
DivyanshGarg380 wants to merge 2 commits into
Conversation
DivyanshGarg380
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 16, 2026 11:34
DivyanshGarg380
marked this pull request as draft
October 16, 2026 11:42
DivyanshGarg380
marked this pull request as ready for review
October 16, 2026 11:42
| if m.Host == "" { | ||
| m.Host = defaultGitHubHost | ||
| } | ||
| if m.Host != strings.ToLower(m.Host) || strings.ContainsAny(m.Host, "/ \t") { |
Collaborator
There was a problem hiding this comment.
i don't think it should matter...
Contributor
Author
There was a problem hiding this comment.
fair point i will drop the uppercase check and keep the path validation.
Contributor
Author
|
Hey, saw the PR was closed. was the change not needed or should i make some changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
GitHub merger configuration currently accepts negative duration values and malformed host values. These configurations should be rejected early to prevent unexpected polling behavior and invalid host configuration.
What?
httpTimeout,pollInterval, andmaxPollDuration.host:portvalues and default configuration.Test Plan
go test ./service/runway/server -run TestLoadMergeConfig_GitHubDurationAndHostValidation -count=1— passed.gofmt -d service\runway\server\config.go service\runway\server\config_test.go— no formatting differences.git diff --cached --check— passed.Issue