Repository navigation
Keep Sort::fromExpression() within the cognitive complexity limit. - #19
Merged
Merged
Conversation
Keeps the cognitive complexity of Sort::fromExpression() within the ruleset limit reported by slevomat/coding-standard 8.31.3. No behavior or public API change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slevomat/coding-standard8.31.3, resolved by any fresh install, reports a cognitive complexity of 7 forSort::fromExpression(), above the limit of 5, somake reviewfails onmain. The method is unchanged since 1.0.0 and passed under 8.31.1.Sort::fromExpression()into the internal value objectInternal\SortToken.Sort::fromExpression()keeps only the empty-expression guard and the mapping.SortTokenlives insrc/Internal/, the existing tests pass unchanged, and the ruleset is untouched.Release
Recommended release: patch (no behavior change).
This unblocks #18 (
chore/require-http-8), whoseauto-reviewjob fails on the same finding.Related issue
None.
Checklist
make reviewpasses.make testspasses.