Repository navigation
feat(task): add per-task CPU frequency - #808
Kanata9020 wants to merge 1 commit into
Conversation
47f27b4 to
25a7bb1
Compare
romancardenas
left a comment
There was a problem hiding this comment.
Thanks! A minor comment
Add `task::spawn_with_freq()` to run a task at a given CPU frequency. A task without a frequency runs at the maximum, and an idle CPU runs at the minimum. The `dvfs` feature enables this. - Add `freq` to `TaskInfo`. - Add `awkernel_lib::dvfs::set_min_cpu_freq()`. - Add test_dvfs_task.
25a7bb1 to
d2074af
Compare
| #[cfg(feature = "dvfs")] | ||
| match freq { | ||
| Some(f) => { | ||
| if let Err(e) = awkernel_lib::dvfs::set_cpu_freq_clamped(f) { |
There was a problem hiding this comment.
Could we also apply the incoming task’s frequency policy when resuming a preempted task? This code only runs before Future::poll. Both yield_and_pool(ctx) in run_main() and the direct switch to a saved context in preempt.rs bypass it. For example, if a max-frequency task preempts a task running at half speed, the latter can resume without its half-speed request being reapplied. Both switch paths should apply the incoming task’s requested frequency, or max if it has no explicit request.
| // CPU#0 is the primary CPU and does not run tasks. | ||
| let min = get_min_cpu_freq(); | ||
| for core in 1..num_cpu() { | ||
| let handle = awkernel_async_lib::spawn( |
There was a problem hiding this comment.
This probe is spawned without a frequency request, so run_main() requests the maximum frequency before the probe calls get_curr_cpu_freq(). The reading is taken while the probe is running, so it can’t tell us whether the scheduler requested the minimum frequency when the CPU went idle. Could we record the result of set_min_cpu_freq() in the idle path and check it afterward instead?
Description
Add
task::spawn_with_freq()to run a task at a given CPU frequency. Thedvfsfeature ofawkernel_async_libenables this, and thedvfsfeature of the kernel now turns it on.run_main()sets the CPU frequency as follows:flowchart TD Start([start]) --> C1{"ready task in queue?"} C1 -- Yes --> P1[retrieve task] C1 -- No --> P0[set min frequency] P1 --> C2{"task has frequency?"} C2 -- Yes --> P3A[set CPU frequency] C2 -- No --> P3B[set max frequency] P3A --> P4[execute task] P3B --> P4 P4 --> C1 P0 --> C1Related links
How was this PR tested?
scripts/ci.shpasses on my machine.Notes for reviewers
test_dvfs.test_dvfschanges the CPU frequency directly instead of usingtask::spawn_with_freq(), sorun_main()overwrites its frequency.test_dvfsshould be removed in the future.test_dvfs_taskprints logs withlog::info!(). The logger task that prints them has no frequency, sorun_main()sets the CPU to the maximum frequency whenever it runs. Printing logs in another way in the future would fix this.