Repository navigation
Conversation
The generated dispatch raised for an operation that it did not generate, so an outbound interceptor could not serve its own System Nexus service. nexgen 0.2.10 passes such an operation to start_system_nexus_operation, so the pin moves to it and the bindings are regenerated.
nexgen 0.2.10 is already released without the fall-through, so check-protos would install it and get other output.
1 of 3 tasks
|
|
moetemp
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This PR sets nexgen to
0.2.11and regenerates the System Nexus bindings. The generated dispatch then passes an operation it didn't generate tostart_system_nexus_operationon the Workflow outbound interceptor, instead of raisingValueError. The other changes in the generated files come from the new nexgen version.Why?
An outbound interceptor can serve its own System Nexus service through
WorkflowOutboundInterceptor.start_system_nexus_operation. The generated dispatch raisedunsupported System Nexus operationbefore that hook ran, so such a service couldn't work in Python.This depends on temporalio/nexgen#260 and the first nexgen release with it,
0.2.11. Until that release exists,check-protosfails because it can't install nexgen0.2.11.Checklist
How was this tested:
tests/nexus/test_system_nexus_fallthrough.pystarts an operation of a service that the SDK didn't generate, and an interceptor completes it. It fails onmainwithunsupported System Nexus operationand passes with this change. I also ranpoe lintand the full suite.Any docs updates needed? No.