Skip to content

Run required PR checks only on pull requests - #3188

Merged
yuandrew merged 1 commit into
mainfrom
yuandrew/pr-checks-only
Nov 3, 2026
Merged

yuandrew merged 1 commit into
mainfrom
yuandrew/pr-checks-only

Conversation

@yuandrew

@yuandrew yuandrew commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

What was changed

Don't run the "Required" CI check in main, since this should only matter for PRs

Why?

Not a big deal at all, but my OCD bothers me that this runs in main CI

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

Note

Low Risk
Workflow-only change that skips a non-functional aggregator job on main; PR merge gating behavior is unchanged.

Overview
The Required PR Checks aggregator job in CI now runs only for pull_request events, not on pushes to main.

Its if condition changes from always() to always() && github.event_name == 'pull_request', so merge-gating still runs when upstream jobs finish (including failures) on PRs, but main branch CI no longer shows or executes that synthetic required check.

Reviewed by Cursor Bugbot for commit 3848f51. Bugbot is set up for automated code reviews on this repo. Configure here.

@yuandrew
yuandrew requested a review from a team as a code owner November 3, 2026 14:23
@yuandrew yuandrew added the skip-changelog PR changes do not require changelog updates label Nov 3, 2026 — with ChatGPT Codex Connector
@yuandrew
yuandrew merged commit c366cce into main Nov 3, 2026
20 of 21 checks passed
@yuandrew
yuandrew deleted the yuandrew/pr-checks-only branch November 3, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog PR changes do not require changelog updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants