Repository navigation
Run required PR checks only on pull requests - #3188
Merged
Merged
Conversation
chris-olszewski
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Don't run the "Required" CI check in main, since this should only matter for PRs
Why?
Not a big deal at all, but my OCD bothers me that this runs in main CI
Checklist
Closes
How was this tested:
Note
Low Risk
Workflow-only change that skips a non-functional aggregator job on main; PR merge gating behavior is unchanged.
Overview
The
Required PR Checksaggregator job in CI now runs only forpull_requestevents, not on pushes tomain.Its
ifcondition changes fromalways()toalways() && github.event_name == 'pull_request', so merge-gating still runs when upstream jobs finish (including failures) on PRs, but main branch CI no longer shows or executes that synthetic required check.Reviewed by Cursor Bugbot for commit 3848f51. Bugbot is set up for automated code reviews on this repo. Configure here.