Repository navigation
Test poller autoscaling signal handling - #3176
Merged
Merged
Conversation
Cover positive and negative scaling deltas, scale-up gating, and poller count limits to catch regressions in server scaling decisions.
yuandrew
commented
Oct 28, 2026
dplyukhin
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added tests covering positive and negative scaling deltas, scale-up gating, and poller count limits to catch regressions in server scaling decisions.
Why?
More tests good
Checklist
Closes
How was this tested:
Note
Low Risk
Test-only changes with no production code or runtime behavior modifications.
Overview
Adds a JUnitParams-driven
applyScalingDecisiontest that exercises howPollScaleReportHandleapplies server poll-request delta suggestions against min/max poller bounds.The cases cover scale-up gating (positive deltas apply only after
run()opens a reporting period; otherwise the count stays unchanged), scale-down for negative deltas regardless of gating, and clamping to the configured minimum (2) and maximum (10), including zero delta and extreme suggestions.Reviewed by Cursor Bugbot for commit 99253ac. Bugbot is set up for automated code reviews on this repo. Configure here.