Repository navigation
feat: route an HTTP server's requests through a forward proxy - #9
Merged
Merged
Conversation
Co-authored-by: tembo[bot] <208362400+tembo-io[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An HTTP server can now set
proxy, a forward proxy that every request to that server goes through. Other servers, and gate's hooks, are unaffected.{ "mcpServers": { "internal": { "url": "https://tools.example.ts.net/mcp", "proxy": "http://localhost:1056" } } }This is for servers that are only reachable through a proxy. Tembo's case is MCP servers on a customer's Tailscale network (tembo/monorepo#13140): a sandbox joins the tailnet with tailscaled in userspace mode, which offers an HTTP proxy rather than routes, so tailnet names and ACLs only apply to requests sent through it.
proxyexpands${VAR}likeurl, and must be anhttporhttpsURL. It's rejected on stdio servers.Tested by
http_servers_can_go_through_a_proxy: two servers, one behind a forward proxy. The proxied server works, and the proxy sees all of its requests and none of the other server's. The test fails without the change, because the proxy then sees nothing. Config tests cover expansion and the rejected cases.