Repository navigation
Conversation
Co-authored-by: tembo[bot] <208362400+tembo-io[bot]@users.noreply.github.com>
Co-authored-by: Vinícius <36349314+vrmiguel@users.noreply.github.com>
Contributor
|
Closing: this hides gate's own environment, but in Tembo's sandbox the same tokens are readable elsewhere by any same-user process (the agent's and shells' environments, and the gateway credential token in a world-readable config file), so it doesn't keep tokens from a hostile server. Real isolation needs servers to run as another user or in a separate sandbox. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hookEnvkeeps hook tokens out of servers' environments, but stdio servers run as the same user as gate, so any of them could still read every token from/proc/<gate's pid>/environ.On Linux, gate now makes itself non-dumpable (
prctl(PR_SET_DUMPABLE, 0)) at startup. That makes its/procfiles,environincluded, belong to root. Gate's children are unaffected: a process becomes dumpable again when itexecs. If the call fails, gate logs a warning and keeps running.This doesn't help when gate and its servers run as root, and macOS has no equivalent, since same-user processes can read each other's environment there too.
Tested by
servers_cannot_read_gates_environment(Linux only), which fails without the change: the server read gate's environment, hook token included.