Repository navigation
fix(nix): link nixpkgs' AWS-LC, as current nixpkgs requires - #7
Merged
Merged
Conversation
Co-authored-by: tembo[bot] <208362400+tembo-io[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Nix package job started failing on
nixos-unstablewith:nixpkgs' cargo setup hook now exports
AWS_LC_SYS_USE_SYSTEM=1for every Rust build (pkgs/build-support/rust/hooks/cargo-setup-hook.sh). That makesaws-lc-syslink a system AWS-LC instead of building its own. This follows nixpkgs' convention for that (as injsonschema-cli):pkg-configinnativeBuildInputsandaws-lcinbuildInputs.Built and smoke-tested against the current
nixos-unstableand against the older nixpkgs revision Tembo's monorepo pins, which doesn't set the variable yet. Cargo builds are unaffected; they still build AWS-LC from source.This is what fails the Nix package check on #6.