Repository navigation
tools: validate REX3 recording headers - #255
Merged
techomancer merged 1 commit intoOct 19, 2026
Merged
Conversation
Closes techomancer#254 Validate the binary REX3 recording header before parsing records. - Reject truncated headers with a clear error. - Reject unsupported recording versions. - Keep valid version-1 binary and text recordings working. Checks: valid v1 binary, truncated header, unsupported version, text input, `py_compile`, and `git diff --check`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #254
Problem
The REX3 recording inspector ignored the binary header version and accepted
truncated headers as empty recordings.
Fix
Check the full header and require recording version 1 before parsing records.
Testing
py_compileandgit diff --check