Repository navigation
Psalm > level 3 - #39
Merged
Merged
Conversation
Fixes the 40 findings level 3 adds on top of level 4, then raises errorLevel to 3 in psalm.xml. Among them: - 404 instead of 500 on the show and listen pages for an unknown uid - captcha check fails closed when Google cannot be reached or answers something unexpected; client IP read from the request - guards on curl handles, preg_split, preg_replace, iconv, json_encode and transliterator results - ellipsis() no longer cuts a long first word down to one letter - Album::merge prefers the other picture when one album has none - typed request values in the login form, non-empty admin identifier, repository class reference on the Item entity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the 40 findings level 3 adds on top of level 4, then raises errorLevel to 3 in psalm.xml. Among them: