Repository navigation
Close ZeroMQ resources during broker shutdown - #707
Open
IlyaKhalafi wants to merge 1 commit into
Open
IlyaKhalafi wants to merge 1 commit into
IlyaKhalafi wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes ZeroMQ brokers leaving their socket and context open after shutdown. With this, resources close even if a shutdown hook or the result backend fails, and the broker can still be started again afterwards.
Sockets close with linger set to zero, so outgoing messages that have not been flushed may be dropped at shutdown.
All 382 tests and the pre-commit checks pass, including nine real-socket cleanup and restart tests. A local TCP stress check with an unread subscriber also passed five runs.
Fixes #706