[ovitrif]

Companion: synonymdev/bitkit-android#1774
Companion: synonymdev/bitkit-ios#1212

Description

After it triggers a timed sheet, triggerTimedSheetUnlessPresent waited up to 3 s for the Move to Spark intro before it went on. On a build without Move to Spark the intro never shows, so every trigger paid the full 3 s. The wait now ends as soon as either the expected sheet or the intro shows, and the intro is dismissed only when it is the one showing.

The probe after a received payment keeps its 3 s. Without the intro, nothing shows there that the wait could stop on.

Testing

• tsc --noEmit, eslint and prettier --check pass on the changed file.
• Measured on synonymdev/bitkit-android E2E run 42597675194, a branch without Move to Spark, against main with test: handle the move to spark intro #297: the intro never showed, no intro recovery fired, and 5 of 6 passing shards ran 0.6–1.9 min longer than run 42585061344 before the merge. Its one failure, @onboarding_2 (receive address differs from Address Viewer), does not touch these helpers and came with the new app base.
• This change has not run in an app's E2E yet.

[chatgpt-codex-connector]

Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-09T10:45:46.012806Z	c857bf6	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[talosmachina]

No findings. triggerTimedSheetUnlessPresent now stops its post-trigger wait as soon as either sheetId or the Move to Spark intro shows, instead of always waiting up to 3 s for the intro. Reviewed c857bf6, full tier.

What I checked, and 3 candidates I ruled out

Read in full: triggerTimedSheetUnlessPresent, dismissInterveningSheets, awaitSheetAfterMoveToSpark, dismissMoveToSparkIntroIfShown, withMoveToSparkIntroRecovery and the four callers (test/helpers/actions.ts:1600,1805,1831,1922).
Build: not run here; this repo reports no checks on the branch, and the PR body says the change has not run in an app E2E yet.

Ruled out

• Intro shows but is missed: when the wait ends on MoveToSparkIntroLater, the following dismissMoveToSparkIntroIfShown() (check-once) sees the same element, so the dismiss and awaitSheetAfterMoveToSpark path is unchanged.
• Timeout throws: the waitUntil rejection is swallowed with .catch(() => undefined), so a run where neither shows behaves as before (3 s, then a single intro check, no throw).
• Intro surfacing after sheetId: the app shows one timed sheet at a time and the intro outranks the others, so it does not appear on top of an already visible sheetId; an intro that comes up later is still caught by withMoveToSparkIntroRecovery in the waits that follow.

Merge confidence: 4/5, no findings, but the helper has not run in any E2E yet and this repo has no CI on the branch.

[pwltr]

Reviewed commit c857bf6. After the timed-sheet trigger, the helper now waits for whichever of the expected sheet or the Move to Spark intro shows first and dismisses the intro only when it is the one showing, so builds without the intro no longer wait out the full 3 s. The no-sheet and intro paths behave as before. No issues found.

Review details

General review
Model: Claude Opus 5.5
Reasoning effort: high

[ovitrif]

Merged: approved by @pwltr, no findings from Talos, no open threads.