You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Low-severity items from the reviews of #1774 that it leaves out:
Tests: MoveToSparkRepo.move() (event matching, the in-flight timeout, the fee cap passed to payInvoiceOverLdk) and the state transitions of MoveToSparkViewModel have no unit tests.
Outcome after Back: leaving the Move to Spark screen while a move runs cancels the screen's wait, since MoveToSparkViewModel is tied to the screen. The payment still goes through, but a successful move then gives no feedback, because the move's notices are muted. Keep the outcome after the screen closes, as iOS's shared MoveToSparkManager does, or block Back while the move runs (QA review).
Restart: MoveToSparkRepo keeps the move's payment hashes in memory only. If the app is killed while the payment is in flight and Spark reports the receive after relaunch, the usual received notice shows. Keep the hash until the payment settles (QA review).
Failure matching by payment id and the Connections button's channel source are fixed in #1774 at f715f9d; this issue keeps only the missing unit tests.
Activity
ovitrif commentedon Nov 6, 2026
Failure matching by payment id and the Connections button's channel source are fixed in #1774 at f715f9d; this issue keeps only the missing unit tests.