Repository navigation
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates focused on improving local development setup, upgrading CI tooling, and expanding test coverage. The most significant changes include the addition of a
.env.templatefor easier environment configuration, updates to SonarCloud scan actions in CI workflows, and a new test to verify correct behavior when assuming multiple switcher keys.Regression test added: should stack keys when assuming multiple keys
Problem found in the JS library. Confirmed that this library has no issues.
Development environment improvements:
.env.templatefile with example environment variables (SWITCHER_URLandSWITCHER_API_KEY) to facilitate local development and integration testing.CI/CD workflow updates:
v8.3.0tov8.4.0in both.github/workflows/master.ymland.github/workflows/sonar.ymlfor improved code analysis and security. [1] [2]Testing enhancements:
tests/switcher-stub.test.tsto ensure that when multiple switcher keys are assumed, the latest assumption for each key takes precedence. This helps verify correct stacking and overriding of key assumptions.