Skip to content

chore: added void to fire-forget promise ops - #110

Merged
petruki merged 6 commits into
masterfrom
staging
Oct 24, 2026
Merged

petruki merged 6 commits into
masterfrom
staging

Conversation

@petruki

@petruki petruki commented Oct 24, 2026

Copy link
Copy Markdown
Member

This pull request introduces several improvements focused on code quality, testing consistency, and dependency updates. The main changes include updating the Deno version used in CI workflows, standardizing test declarations across multiple test files, and improving code correctness by explicitly handling asynchronous calls.

Dependency and Workflow Updates:

  • Updated Deno version from v2.9.7 to v2.9.8 in all GitHub workflow files to ensure the project uses the latest stable runtime in CI. [1] [2] [3]

Testing Consistency:

Code Quality Improvements:

  • Added explicit void usage before asynchronous function calls (e.g., void this.loadSnapshot(), void checkAPIHealth(...)) in source files to clarify intentional non-handling of returned Promises and prevent unhandled promise rejections. [1] [2] [3] [4] [5]

These changes collectively improve maintainability, reliability, and clarity in both the codebase and CI processes.

@petruki petruki added this to the v2.5.1 milestone Oct 24, 2026
@sonarqubecloud

Copy link
Copy Markdown

@petruki
petruki merged commit e6fc7bb into master Oct 24, 2026
5 checks passed
@petruki
petruki deleted the staging branch October 24, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant