Repository navigation
phpstan: install PHP from setup-php's prebuilt builds on Blacksmith | SMTNC-3595 - #36
Conversation
Blacksmith runners report themselves as self-hosted, so setup-php apt-installed PHP from the Launchpad PPA on every run and failed with only "Could not setup PHP 7.4" whenever Launchpad was slow or down. use_builds_cache makes it download the prebuilt PHP that GitHub-hosted runners get. It is set only on Blacksmith runners, so GitHub-hosted and other self-hosted runners keep their current path.
|
@coderabbitai review |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Action not completed
|
Blacksmith runners report themselves as self-hosted, so setup-php apt-installs PHP from the Launchpad PPA on every PHPStan run. It fails with only
Could not setup PHP 7.4whenever Launchpad is slow or down: 259 such failed jobs in learndash-core since its move to Blacksmith on 2026-09-21. On Blacksmith this setsuse_builds_cache, so setup-php downloads the prebuilt PHP that GitHub-hosted runners get. On other runners the value stays empty, because setup-php reads an explicitfalseas "use the PPA", even on GitHub-hosted runners.Evidence
[OK] No errors.use_builds_cachepasses 10/10.Companion change for learndash-core's own workflows: https://github.com/stellarwp/learndash-core/pull/3880
Summary by CodeRabbit