Repository navigation
fix: emit missing symbol information - #226
Merged
chrapkowski-sg merged 6 commits intoNov 2, 2026
Merged
chrapkowski-sg merged 6 commits into
chrapkowski-sg merged 6 commits into
Conversation
Contributor
Author
|
I know it's bad form... but this is one-shot from codex. This PR does fix the bug I encountered though: I tested this fix against OpenGHG, a medium-sized Python package for processing atmospheric greenhouse-gas measurement and modelling data. Using the same OpenGHG checkout and scip-cli 2.7.0:
This is a controlled before/after test and confirms that the PR fixes the missing-SymbolInformation failure on a real-world Python codebase. (Again, apologies for the AI generated summary... scip-python seems useful and I want to try it out, but I don't have time to dig into the code myself.) |
chrapkowski-sg
marked this pull request as ready for review
November 2, 2026 22:00
chrapkowski-sg
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #223.
Ensures cached class definitions still emit
SymbolInformationand records identity-only information for undocumented external symbols. Retains the reported reproduction and structural regression checks.Empty external records can acquire documentation from later visits; populated records are never replaced by empty placeholders. This avoids making documentation depend on import order. Local modules shadowing installed packages must not acquire external records.
External-symbol metadata is optional in SCIP. The structural checks establish this project's compatibility expectations; they are not a claim that every external reference requires metadata under the protocol.
Verification
import numbers/from numbers import Realorders and a local module shadowing an installed package.