Repository navigation
ci: scope the golang job token to the permissions it needs - #744
Merged
Merged
Conversation
The app token inherited every permission of the installation. It now gets only contents, pull requests, and workflows, which the job needs to push the version bump and open a pull request.
mwbrooks
added
code health
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
==========================================
- Coverage 78.20% 78.18% -0.02%
==========================================
Files 240 240
Lines 18179 18179
==========================================
- Hits 14216 14214 -2
- Misses 3963 3965 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Thanks @zimeg for the quick review! 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request gives the
golangjob's app token only the permissions it needs, for maintainers who want the dependency workflows to follow least privilege. The token used to inherit every permission of the releaser app installation, which zizmor flags.contents: writeto push the version bump branch.pull-requests: writeto open the pull request with its labels and milestone.workflows: writebecause the bump edits.github/workflows/tests.yml, and GitHub rejects a push that changes a workflow file without it.Testing
workflow_dispatchand confirm the "Bump the Golang version" job passes. It exits early with "No changes to commit" while Go is current.Notes
skilljob in ci: sync the slack-cli skill from slack-skills-plugin each day #736, from @zimeg's review there.Requirements