Skip to content

fix(block-kit): set verbatim false on the carousel block example text - #103

Merged
mwbrooks merged 2 commits into
mainfrom
docs-drift-carousel
Nov 6, 2026
Merged

mwbrooks merged 2 commits into
mainfrom
docs-drift-carousel

Conversation

@zimeg

@zimeg zimeg commented Nov 5, 2026

Copy link
Copy Markdown
Member

Summary

This pull request adds "verbatim": false to the mrkdwn text objects of each card in the carousel block example to match the carousel block docs.

  • title, subtitle, and body on all three cards now set .verbatim(false) inline in the builder, since the SDK only serializes verbatim when it's set.
  • CarouselTest expects $.elements[0..2].title.verbatim, $.elements[0..2].subtitle.verbatim, and $.elements[0..2].body.verbatim as false (previously missing) to match the docs JSON.

Testing

  • Post Carousel.example01() to a test channel with chat.postMessage and confirm the carousel renders and each stored card keeps "verbatim": false on the title, subtitle, and body.

🤖 Generated with Claude Code

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@zimeg zimeg added documentation Improvements or additions to documentation java Pull requests that update java code labels Nov 5, 2026
@zimeg zimeg self-assigned this Nov 5, 2026
@zimeg
zimeg marked this pull request as ready for review November 5, 2026 19:36
@zimeg
zimeg requested a review from a team as a code owner November 5, 2026 19:36
@zimeg zimeg changed the title fix(block-kit): match the carousel block example to the docs fix(block-kit): set verbatim false on the carousel block example text Nov 5, 2026

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks @zimeg! All three carousel cards now line up with the docs JSON, right down to the verbatim flag.

.title(BlockCompositions.markdownText("MDR"))
.subtitle(BlockCompositions.markdownText("Refining data files"))
.title(BlockCompositions.markdownText(
mt -> mt.text("MDR").verbatim(false)))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Same pattern as the card example across all three cards, and CarouselTest now matches the carousel docs JSON field for field.

@mwbrooks
mwbrooks merged commit dd3a10b into main Nov 6, 2026
4 checks passed
@mwbrooks
mwbrooks deleted the docs-drift-carousel branch November 6, 2026 05:13
@zimeg

zimeg commented Nov 6, 2026

Copy link
Copy Markdown
Member Author

🌟 Thanks for the kind review and merge @mwbrooks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation java Pull requests that update java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants