Skip to content

fix(block-kit): set verbatim false on the card block example text - #102

Merged
mwbrooks merged 2 commits into
mainfrom
docs-drift-card
Nov 6, 2026
Merged

mwbrooks merged 2 commits into
mainfrom
docs-drift-card

Conversation

@zimeg

@zimeg zimeg commented Nov 5, 2026

Copy link
Copy Markdown
Member

Summary

This pull request adds "verbatim": false to the card block example's mrkdwn text objects to match the card block docs.

  • title, subtitle, and body now set .verbatim(false) inline in the builder, since the SDK only serializes verbatim when it's set.
  • CardTest expects $.title.verbatim, $.subtitle.verbatim, and $.body.verbatim as false (previously missing) to match the docs JSON.

Testing

  • Post Card.example01() to a test channel with chat.postMessage and confirm the card renders and the stored block keeps "verbatim": false on the title, subtitle, and body.

🤖 Generated with Claude Code

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@zimeg zimeg added documentation Improvements or additions to documentation java Pull requests that update java code labels Nov 5, 2026
@zimeg zimeg self-assigned this Nov 5, 2026
@zimeg
zimeg marked this pull request as ready for review November 5, 2026 19:36
@zimeg
zimeg requested a review from a team as a code owner November 5, 2026 19:36
@zimeg zimeg changed the title fix(block-kit): match the card block example to the docs fix(block-kit): set verbatim false on the card block example text Nov 5, 2026

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks @zimeg! The card example and its test now match the docs JSON right down to the verbatim flag.

.title(BlockCompositions.markdownText("Lumon Industries"))
.subtitle(BlockCompositions.markdownText("Committed to work-life balance"))
.title(BlockCompositions.markdownText(
mt -> mt.text("Lumon Industries").verbatim(false)))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Setting .verbatim(false) inline on each text object is the right call, since the SDK only serializes verbatim when it is set. The test now pins the exact docs JSON too 🎴

@mwbrooks
mwbrooks merged commit 480f800 into main Nov 6, 2026
4 checks passed
@mwbrooks
mwbrooks deleted the docs-drift-card branch November 6, 2026 05:12
@zimeg

zimeg commented Nov 6, 2026

Copy link
Copy Markdown
Member Author

🌟 Thanks for the kind review and merge @mwbrooks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation java Pull requests that update java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants