Repository navigation
Fix duplicate New-MonkeyDiagnosticSettingObject dropping resources - #197
Open
JoePhanDro wants to merge 1 commit into
Open
JoePhanDro wants to merge 1 commit into
JoePhanDro wants to merge 1 commit into
Conversation
Rename the helpers/diagnosticSettings variant to New-MonkeyAzDiagnosticObject so it no longer shadows the null-tolerant utils version. Return the input object from Get-MonkeyAzDiagnosticSettingForResource on error when -AddToObject is set. Fixes silverhack#196
Contributor
Pull request targets
|
Up to standards ✅🟢 Issues
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the helpers/diagnosticSettings variant to New-MonkeyAzDiagnosticObject so it no longer shadows the null-tolerant utils version. Return the input object from Get-MonkeyAzDiagnosticSettingForResource on error when -AddToObject is set.
Fixes #196
Context
Please include a summary of the changes. Please also include relevant motivation and context for this PR.
Description
Please include a summary of the change and which issue is fixed.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.