[shadowhand]

No description provided.

[shadowhand]

/robin

[github-actions]

The Robin Hood of code review

✅ Review done. I flagged 3 things worth a look.

Push fixes whenever you like, then comment /robin for another pass.

_{Robin v2.12.3 · antongulin/robin@main (3c3c2ad) · diff-only review (agent mode off)}

[github-actions]

The Robin Hood of code review

Heads up: this is a point-in-time review. Push fixes freely, then comment /robin whenever you want another pass.

⚠️ 1 Medium | 🔵 1 Low | 💡 1 Suggestions

Summary

The diff replaces PHP serialization with JSON for route caching and adds JsonSerializable plus runtime type coercion for Route and RouteCollection, which removes the unserialize RCE risk and centralizes cache validation. The round-trip design and added tests are generally sound. The main outstanding issues are documentation and API-change hygiene: docs/cache.md still references the old default cache file name after the code default changed, and the narrowed RouteCache return types were not reflected in the changelog.

---

📄 Findings Not Posted Inline

💡 1 (CHANGELOG.md) — The Unreleased changelog entry does not note the narrowed return types on RouteCache::read() and RouteCache::write().

Add a changelog entry for the API change.