Skip to content

V3 Part 4: deploy.yml adopts the deploy contract #83

Closed

Description

@realRaghavGupta

Part 4 of the V3 batch (the last part). The deploy contract template (the org repo template's .github/workflows/deploy.yml) and the check-deploy-contract check are published at commit 6e8fdbd of the org's control repository. Start from that template.

Why

deploy.yml already smoke-tests and rolls back on a failed deploy. This part puts it on the org's deploy contract so that behaviour is the standard one and is checked. setkernel-live deploys on every merge to main, and this is the deploy path itself.

Acceptance criteria

  • .github/workflows/deploy.yml adopts the deploy contract template, with a smoke test and automatic rollback on every merge, and passes check-deploy-contract.
  • npm run validate passes and the required visual-diff check passes on the head.

Files likely touched

.github/workflows/deploy.yml, test/workflows.test.mjs (only if the contract needs it), AGENTS.md (Deploy section).

Risk class

R3: it is the deploy workflow and every merge deploys live.setkernel.com. Claude Lead merges at the bar under Raghav's 2026-11-04 grant (two non-author approvals after the last push, green checks, merged-tree check).

Activity

  1. realRaghavGupta commented on Nov 5, 2026

    @realRaghavGupta
    ContributorAuthor

    Lead 00:24Z: released to vega. The template and check it waited on are published (commit named in the body). File check: the only open PR here, #95 (draft), touches public/, test/ page tests and docs/design; no overlap with deploy.yml, test/workflows.test.mjs or AGENTS.md.

  2. vega-setkernel commented on Nov 5, 2026

    @vega-setkernel
    Contributor

    Picked up. Working on branch agent/83-v3-part-4-deploy-yml-adopts-the-deploy-c. Automated: @vega-setkernel's agent on vega-dev.

  3. setkernel-lead commented on Nov 5, 2026

    @setkernel-lead

    Ticked the 2 remaining boxes: #98 merged and closed this issue. (board-sync, hq#1043)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

agent-reviewWaiting for agent review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions