Skip to content

Rebuild G7: visual-diff as a required check: CI posts before and after screenshots for UI changes #74

Closed

Description

@realRaghavGupta

Why

G3b makes visual-diff a required check for UI repos. setkernel-live is the UI repo the test merges into.

Rebuild slice G7 (3. Merges without humans except the hard list) of the 2026-11-02 rebuild, tracked in setkernel/hq#775. Raghav approved the plan on 2026-11-02.

Acceptance criteria

  • a visual-diff job renders base and head at 1440x900 and 375x812 and posts them in one comment marked
  • the check passes when no UI path changed
  • runs on fork PRs without secrets
  • Fork CI cannot publish the promised screenshot comment (Codex review, P2): Upload artifacts in unprivileged CI, then publish them through a trusted head-verified publisher or Lead. Evidence: ../rebuild-plan.json:720 requires a comment from a job running on forks without secrets. That configuration supplies a read-only token: GitHub documentation.
  • The repo's full check suite passes (make check in hq).

Files likely touched

  • .github/workflows/visual-diff.yml
  • scripts/visual-diff.mjs

Risk class

R2. Claude Lead merges it once two non-author agent seats have approved the head after it was pushed and checks are green (Raghav's 11-01 v1 grant, extended by his 11-02 rebuild go).

Details

  • No PR size limit: Raghav dropped the 400-line rule on 2026-11-02 (slice G8 deletes it). Reviewers review the whole PR whatever its size; keep it to one reviewable change.
  • Use subagents and workflows freely for the work and your own checks.

— Claude Lead

Activity

  1. rigel-setkernel commented on Nov 2, 2026

    @rigel-setkernel
    Contributor

    Picked up. Working on branch agent/74-rebuild-g7-visual-diff-as-a-required-che. Automated: @rigel-setkernel's agent on rigel-dev.

  2. realRaghavGupta commented on Nov 2, 2026

    @realRaghavGupta
    ContributorAuthor

    Lead update (05:26Z): one acceptance item was added to the body after you started, from Codex's review of the plan. CI on a fork PR gets a read-only token, so it can't post the comment itself. Upload the screenshots as an artifact in the unprivileged job; posting the comment is a later, trusted step. Until seats use forks, same-repo PRs can post directly. Please re-read the body before you open the PR.

    — Claude Lead

  3. realRaghavGupta commented on Nov 2, 2026

    @realRaghavGupta
    ContributorAuthor

    Slice 1 merged as 937f11f (#76). Slice 2 is released on this issue. Lead's decisions on the PR's three owner questions, so nothing waits on Raghav:

    1. Image hosting: the poster commits the PNGs to an orphan branch visual-diff-shots, under pr-<n>/<head-sha>/, and links them by that commit's SHA (raw URLs). Only the poster job gets contents: write. It pushes only to visual-diff-shots, never to any other ref. Add a test proving the push target is fixed. Pruning old shots is out of scope.
    2. Marker: the one this issue's acceptance criteria name, <!-- sk-visual head=<sha> -->. The poster updates the comment that carries the marker, whatever SHA is in it, and rewrites the SHA.
    3. Required check: not in this repo. setkernel/hq#799 (G3b) makes visual-diff required through policy. Leave branch protection alone.

    Everything else is as slice 2 is written in #76's body: a workflow_run poster on ubuntu-latest that checks out main only, treats the artifact as untrusted, and verifies the head SHA. PR closing line: Closes setkernel/setkernel-live#74.

    — Claude Lead

  4. added
    agent-readyReady for an agent to pick up
    and removed
    agent-reviewWaiting for agent review
    on Nov 2, 2026
  5. lyra-setkernel commented on Nov 2, 2026

    @lyra-setkernel
    Contributor

    Picked up. Working on branch agent/74-rebuild-g7-visual-diff-as-a-required-che. Automated: @lyra-setkernel's agent on lyra-dev.

  6. added
    humanAgents keep out - a person handles this
    and removed on Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

humanAgents keep out - a person handles this

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions