Repository navigation
Fresh start on central agent management (remove per-repo agent files and git hooks) - #4
Conversation
Delete the per-repo .claude/ scaffolding (agents, skills, settings, cloud-setup): the setkernel plugin and managed settings provide them. Rewrite AGENTS.md from the hq template with this repo's own facts only (what it is, commands, deploy, layout, traps) and add the agent-task issue template. CLAUDE.md stays the @AGENTS.md pointer; CODEOWNERS already matched the standard. Refs setkernel/hq#46 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vega-setkernel
left a comment
There was a problem hiding this comment.
Good. This PR covers every item in #3 and nothing else. register.ps1, the workflows and the deploy path are unchanged, so it can't affect devices.
.claude/is deleted completely.git ls-tree origin/mainshows 7 tracked files, which matches the PR body; the issue's "12 files" was a count from the scan. The repo has no other AI configs or git hooks to remove.agent-task.ymlis byte-identical to hqagents/github/templates/.github/ISSUE_TEMPLATE/agent-task.yml. Checked withdiffagainst the hq API: same. Theagent-readylabel it applies exists in this repo.AGENTS.mdfollows the template on hq#86 (standard/central-agents-fresh-start) section for section, and drops the copied org rules. I checked each fact against the code:Stop-Hereexists (register.ps1:45).- The child
powershell.exeuploader is at:123-129. - The Home SKUs 98–101 are at
:72. - The group-tag regex is at
:61, and the tag is interpolated into$innerat:127. - The redirect is real:
setkernel-cloudflarestacks/edge/rulesets.tf:167setkernel_net_redirects, withtarget_urlset to.../autopilot/main/register.ps1.
- Nothing repo-specific was lost from
.claude/settings.json. Its deny rules (force-push, wrangler deploy, .env reads) are generic and now come from managed settings.cloud-setup.shdid nothing here. - CI (PowerShell parse check) is green. I couldn't run
scripts/check.shlocally because pwsh isn't installed on this VM, but no.ps1changed.
Nits (not blocking):
- Merge order: the new
AGENTS.mdlinks tohq/blob/main/docs/repo-standard.md, which returns 404 on hqmainuntil hq#86 merges. Merge hq#86 first, or accept a broken link for a short time. Resync the wording if #86 changes. - The old "stop and ask before changing the redirect" line is gone. The org standard covers stop-and-ask, and Deploy still says a merge reaches devices within minutes, so this is fine. A one-line trap saying "changes to
mainare live on the fleet" would still be worth adding. - Agree with the author: open a follow-up to drop the
vars.CI_RUNNERfallback inmerge-audit.yml. It's inert while the repo is public.
Automated: @vega-setkernel's agent on vega-dev.
vega-setkernel
left a comment
There was a problem hiding this comment.
Review of #4: fresh start on central agent management
What's good
- The scope matches issue #3 and nothing else is in the diff.
register.ps1,ci.yml,CODEOWNERSandCLAUDE.mdare unchanged. - All 7 tracked
.claude/files are deleted. A scan oforigin/mainturned up no.agents/, other AI tool configs, git hooks or hook installers, so there was nothing else to delete. .github/ISSUE_TEMPLATE/agent-task.ymlis byte-identical to hqagents/github/templates/.github/ISSUE_TEMPLATE/agent-task.yml(checked withdiff).AGENTS.mdfollows hqtemplates/repo/AGENTS.md. hq#86 is now merged, so the resync worry in the PR body no longer applies. I checked the facts againstregister.ps1:Stop-Hereandreturnat L44-45, the childpowershell.exeat L123-129, the group-tag regex interpolated into-Commandat L60-61 and L127, and Home SKUs 98-101 at L72. All are accurate. Namingsetkernel-cloudflarestacks/edge/rulesets.tffor the redirect is a real improvement.- No secrets, tenant IDs or personal data were added.
- CI's
PowerShell parse checkpasses on head 73c0d1d../scripts/check.shdid not run locally because pwsh is not installed on the review VM (exit 1,check: pwsh is not installed).register.ps1is unchanged, so no OOBE run is needed.
Required changes
- Rebase on
mainand dropmerge-audit.ymlfrom AGENTS.md's Layout.mainhas moved since this branch was cut: bd22e3d (ci: remove merge-audit (#5), Refs setkernel/hq#98) deleted.github/workflows/merge-audit.yml. The branch still merges cleanly (git merge-treereports no conflicts). But the mergedAGENTS.md:36-37would describe a workflow that no longer exists (merge-audit.yml(flags changes tomainwithout Raghav's merge or approval)). That makes the one file this PR rewrites wrong on day one. The Layout line should read just`.github/workflows/ci.yml`: parse check(or list.github/with ci.yml, dependabot.yml, CODEOWNERS and ISSUE_TEMPLATE). After the rebase, the PR body's "For the reviewer" note aboutCI_RUNNERin merge-audit is moot and can go.
Nits (optional)
- The issue said
.claude/ (12 files), but only 7 were tracked. The PR body already says "7 tracked files", which is correct; the scan probably counted untracked files.
Automated: @vega-setkernel's agent on vega-dev.
…n-central-agent-management
|
The branch now includes Required change 1 (rebase on
Nits:
Blocked on owner
Changed
Found
Automated: @orion-setkernel's agent on |
vega-setkernel
left a comment
There was a problem hiding this comment.
Approve. The PR does what #3 asks, nothing more, and register.ps1 is untouched.
Good
.claude/is fully removed (7 tracked files). The tree has no hooks,.agents/, or other AI tool configs, and nothing in README or scripts refers to the deleted files.AGENTS.mdfollows hqtemplates/repo/AGENTS.mdon hqmain(hq#86 is now merged, so the PR's resync worry no longer applies). It carries only facts about this repo; the org rules are gone.- I checked every repo fact in
AGENTS.mdagainst the code:Stop-Here …; return:register.ps1:45- the child
powershell.exeuploader:register.ps1:123-129 - the group-tag regex and its interpolation into
-Command:register.ps1:61,127 - the Home SKUs 98–101:
register.ps1:72 ci.ymlonubuntu-latest, with actions SHA-pinned
- The Deploy section is correct:
setkernel-cloudflarestacks/edge/rulesets.tfsetkernel_net_redirectsis a 302 toraw.githubusercontent.com/setkernel/autopilot/main/register.ps1. .github/ISSUE_TEMPLATE/agent-task.ymlis byte-identical to hqagents/github/templates/.github/ISSUE_TEMPLATE/agent-task.yml, and theagent-readylabel exists in this repo.CLAUDE.mdis identical to the template, and CODEOWNERS is present.- No secrets, and the safety knowledge from the old file (iex/exit, PS 5.1, guards, public repo, hosted runners only, OOBE test run) all made it into the new one.
Checks
- I could not run
./scripts/check.shhere because pwsh is not installed on this VM (check: pwsh is not installed). CI's parse check is green, and the change touches no.ps1.
Nits (not blocking)
- The PR body's 'For the reviewer' note about
merge-audit.yml/CI_RUNNERis stale: #5 removed that workflow and this branch merged it. Worth trimming so nobody files a follow-up for it. .gitignorestill listsTASKS.md, which was a convention of the old AGENTS.md that is now gone. It's harmless, but could go in a later cleanup.- Layout could also mention
.github/dependabot.yml, since Traps relies on Dependabot. Optional.
No required changes.
Automated: @vega-setkernel's agent on vega-dev.
|
R3: this deletes the repo's — Claude Lead |
rigel-setkernel
left a comment
There was a problem hiding this comment.
Approve. Small diff (about 130 changed lines, under the 400 limit). It does what #3 asks and nothing else.
Checked
- Deletions: all 7 tracked
.claude/files are removed. No references to them remain in README,.githubor scripts..gitignorestill listsTASKS.md, which is harmless. AGENTS.mdrewrite: the org rules are gone and the repo-specific facts are kept. I confirmed inregister.ps1thatStop-Here, the childpowershell.exeuploader, the Home SKU guard (98-101) and the group-tag regex^[A-Za-z0-9._-]{1,250}$all exist as described.ci.ymlruns onubuntu-latestwithactions/checkoutpinned to a SHA with a version comment, matching the Traps section. The only workflow left isci.yml. Themerge-audit.ymlmentioned in the PR body no longer exists on this branch, so the runner/CI_RUNNERfollow-up is moot here..github/ISSUE_TEMPLATE/agent-task.ymlloads as valid YAML. I did not diff it against hq.- No secrets, no workflow changes, and
register.ps1is untouched, so no OOBE device run is needed. ./scripts/check.sh:register.ps1parses and the script exits ok. PSScriptAnalyzer is not installed on this VM, so lint was not run.
Minor nits (not blocking)
- I did not check the
setkernel-cloudflarerulesets.tfclaim (redirect path, resource namesetkernel_net_redirects). - The template wording comes from open hq#86. Resync
AGENTS.mdif that wording changes before merge. - The Layout section lists
scripts/check.shandci.ymlbut not.github/CODEOWNERSor the issue template. Optional.
No required changes.
Automated: @rigel-setkernel's agent on rigel-dev.
vega-setkernel
left a comment
There was a problem hiding this comment.
Looks good. Ready to merge apart from the process notes below.
Size: 74 added and 157 deleted, so 231 changed lines. Under the 400 limit, so I reviewed it in one pass.
Checked
- Every deletion is under
.claude/: 2 agents, 3 skills,settings.jsonandcloud-setup.sh. Central managed settings and thesetkernelplugin replace them.cloud-setup.shdid nothing here, since the repo has no.env.exampleor.dev.vars.example. - The tree has no
.agents/, no git hooks and noprepare/postinstallhooks.CLAUDE.mdis the standard pointer andCODEOWNERSis untouched. - The rewritten
AGENTS.mdkeeps the repo-specific facts from the old one:- the redirect, the repo name and the public visibility
- no secrets, and no top-level
exitunderiex - PowerShell 5.1, and the Home SKU 98–101 and group-tag guards
- GitHub-hosted runners only, and the OOBE device run for behaviour changes
- The new claims match the code.
Stop-Here …; returnand the childpowershell.exeuploader are atregister.ps1:45and:123-129. The group tag is interpolated into the child-Commandstring at:127. The README "Hardening before fleet rollout" section exists. The workflow list is justci.yml, so the merge-audit mention is gone. - The org rules that were copied in (tracking, working agreement, conventions, agent tooling) are removed, as the standard asks.
register.ps1is unchanged, so no OOBE device run is needed.agent-task.ymlis valid and carries the credentials pointer. I did not diff it against hq's copy.- I ran
./scripts/check.shhere:register.ps1parses and the script endscheck: ok. PSScriptAnalyzer is not installed on this VM, so lint was not run.
Nits, none blocking
- I could not confirm the Deploy claim that the redirect lives in
setkernel-cloudflarestacks/edge/rulesets.tf(setkernel_net_redirects). I did not read that repo. The PR author says they checked it. - The
AGENTS.mdtemplate comes from the still-open hq#86. If its wording changes before merge, a small resync may be needed. - The
CI_RUNNERnote in the PR body no longer applies.merge-audit.ymlis already gone from this branch, andorigin/mainno longer has it either.
Process: this removes agent runtime and policy files, which is probably R3 under the org rules. If so, it needs two approvals, Codex, a visual diff and Raghav's /approve <sha> on the head commit 68934e7 before the merge App merges it.
Automated: @vega-setkernel's agent on vega-dev.
|
This round only: this repo is public, and the new Keep the facts and drop the pointer. For example: " Everything else is settled: rigel and vega both approved — Claude Lead |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
I removed the private-repo pointers from Blocked on owner
Changed
Found
Checks (setkernel:verify, read by the worker)
Automated: @orion-setkernel's agent on |
921ac09
|
Reviewer: no blockers. Automated: @orion-setkernel's agent on |
vega-setkernel
left a comment
There was a problem hiding this comment.
Approve. The PR does what #3 asks and nothing else. register.ps1, ci.yml, CODEOWNERS and CLAUDE.md are untouched.
Size: 73 lines added and 144 deleted (about 217 changed), under the 400 limit, so I reviewed it in one pass.
Checked
- All 7 tracked
.claude/files are deleted. No references to them remain in README, scripts or.github. The tree has no.agents/, git hooks or hook installers. .github/ISSUE_TEMPLATE/agent-task.ymlis byte-identical to hqagents/github/templates/.github/ISSUE_TEMPLATE/agent-task.ymlon hq main. I randiffagainst the GitHub API and it printed no differences.- The
AGENTS.mdrewrite follows the hqtemplates/repo/AGENTS.mdsections. Org rules are removed and the repo-only facts are kept: the redirect, the repo name and public visibility, no secrets, no top-levelexitunderiex, PowerShell 5.1, the Home SKU and group-tag guards, GitHub-hosted runners only, and the OOBE device run. - The Deploy claim is correct. I read
setkernel-cloudflarestacks/edge/rulesets.tfvia the API: the/aprule is a 302 tohttps://raw.githubusercontent.com/setkernel/autopilot/main/register.ps1. The text names no private path, which is fine for a public repo. docs/repo-standard.mdexists on hq main, so the link in the template text resolves.- The branch merges cleanly with
origin/main(git merge-treereports no conflicts). The workflow list is justci.yml. ./scripts/check.shprintsregister.ps1 parsesandcheck: ok. PSScriptAnalyzer is not installed on this VM, so lint was not run. No.ps1changed, so no OOBE device run is needed.
Nits (none block the merge)
- The PR body's "For the reviewer" note about
merge-audit.ymlandCI_RUNNERis stale. #5 removed that workflow, so no follow-up is needed. The hq#86 resync worry no longer applies either, because the template is on hq main. Worth trimming the PR body. .gitignorestill ignoresTASKS.md. That convention came from the oldAGENTS.mdand is gone, so the entry can go in a later cleanup.- The old "stop and ask before changing the redirect" line is dropped. The org rules cover stop-and-ask, and Deploy says a merge to
mainreaches devices within minutes. A one-line trap saying that changes tomainare live on the fleet would still help.
Process: this removes agent runtime and policy files, so it is likely R3 under the org rules. It still needs the quorum on head 921ac09, including Raghav's /approve <sha>. I am not the merge gate.
Automated: @vega-setkernel's agent on vega-dev.
|
Approvals that count toward the two a merge needs: 1 (vega-setkernel) on head Automated: @vega-setkernel's agent on |
lyra-setkernel
left a comment
There was a problem hiding this comment.
Approve. The change is small (about 130 changed lines, mostly deletions) and matches issue #3.
What I checked
.claude/is removed (7 tracked files: agents, skills,settings.json,cloud-setup.sh). The repo has no.agents/, no other AI tool configs, no git hooks and nopreparehook, so nothing else needed deleting. Grepping for.claude,cloud-setup,ship-pr,merge-auditanddependabotturns up nothing dangling. The oneDependabothit is the intended "there is no Dependabot" note in AGENTS.md.AGENTS.mdfollows the hq template sections (what it is, commands, deploy, layout, traps). The copied org rules are gone. The repo-specific facts are kept: redirect and pinning, public repo and name, no secrets, neverexitunderiex, PS 5.1 and the SKU / group-tag guards, GitHub-hosted runners only, the OOBE test-device requirement. Layout matches the repo (register.ps1,scripts/check.sh,ci.ymlonly). The Deploy section names no private repo or path.CLAUDE.mdis already the pointer andCODEOWNERSalready has* @realRaghavGupta..github/ISSUE_TEMPLATE/agent-task.ymlis valid YAML and carries the credentials pointer../scripts/check.shpasses:register.ps1parses. PSScriptAnalyzer is not installed on this VM, so lint is reported as not run.register.ps1and the workflows are untouched, so nothing here reaches devices.
Nits (not blocking)
- The PR body's "For the reviewer" note about
merge-audit.ymlandCI_RUNNERis stale: that workflow is already gone from this branch, andci.ymlis the only workflow. Drop that note so it doesn't spawn a pointless follow-up. - hq#86 is merged now, and the current hq
templates/repo/AGENTS.mdhas moved on. It namesmake check(withMakefile,mk/*.mkandtools/check.sh) and linksdocs/repo-standard.mdin the header. This repo's Commands section still points at./scripts/check.sh, which is accurate today and consistent with the issue's scope. Themake checkmove belongs in the separate migration, so I'd track it there and not block this PR on it.
Merge note: this deletes agent settings and policy files, so it likely falls in the R3 risk class and needs the full quorum, including Raghav's /approve <sha>. I did not confirm the class in policy/risk.yml.
Automated: @lyra-setkernel's agent on lyra-dev.
|
Approvals that count toward the two a merge needs: 2 (lyra-setkernel vega-setkernel) on head Automated: @lyra-setkernel's agent on |
realRaghavGupta
left a comment
There was a problem hiding this comment.
/approve 921ac09
Summary
Moves this repo onto setkernel's central agent management (hq#86,
docs/repo-standard.md). The repo now holds only its own facts. Org rules, subagents, skills, hooks and permissions come from managed settings and thesetkernelplugin.Closes #3
Refs setkernel/hq#46
Deleted
.claude/(7 tracked files):agents/explorer.mdandagents/reviewer.mdskills/verify,skills/review-blockersandskills/ship-prsettings.json: deny rules plus the SessionStart hook, now covered by managed settingscloud-setup.sh: this repo has no.env/.dev.varsexamples, so it did nothing hereThe repo had none of the other items in the standard's "must not contain" list: no
.agents/, no other AI tool configs, no git hooks and noprepare/postinstallhook installers. So nothing else was deleted.Changed / added
AGENTS.mdis rewritten from hqtemplates/repo/AGENTS.md, taken from the PR #86 branch becausemainstill has the old template. It has the sections what it is, commands, deploy, layout, and traps. The org rules it used to copy (tracking, working agreement, conventions, agent tooling) are removed..agents/folder, sodocs/was not needed. The repo-specific facts from the oldAGENTS.mdmoved into the new one's Deploy and Traps sections:exitunderiexmain/register.ps1, managed outside this repository. It names no private repo or path. The oldAGENTS.mdonly said "managed outside this repository by the owner"..github/ISSUE_TEMPLATE/agent-task.ymlis added, copied verbatim from hqagents/github/templates/.CLAUDE.mdalready matchestemplates/repo/CLAUDE.mdexactly, and.github/CODEOWNERSalready contains* @realRaghavGupta.How it was tested
./scripts/check.shpasses:register.ps1parses. pwsh 7.6.6 was downloaded for the run; PSScriptAnalyzer is not installed, so lint was skipped..ps1) by hand: 0 errors.agent-task.ymlloads as valid YAML.register.ps1is unchanged, so no OOBE device run is needed.For the reviewer
merge-audit.ymlpicks its runner withvars.CI_RUNNER || 'setkernel-linux', but only when the repo is private. This public repo always getsubuntu-latest. The standard retires theCI_RUNNERvariable, but the issue says not to touch workflows, so I left it alone. It may need a follow-up so the fallback doesn't depend on that variable.AGENTS.mdmay need a small resync.🤖 Generated with Claude Code
Closes #3
Automated: @orion-setkernel's agent on
orion-dev.