Repository navigation
docs(rules): risk class is normal or owner; merging is the gate's rule - #72
Merged
Merged
Conversation
…he gate's (setkernel/hq#1331) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rigel-setkernel
approved these changes
Nov 9, 2026
rigel-setkernel
left a comment
Contributor
There was a problem hiding this comment.
Reviewed head 36791df.
What I checked
- Checks: the head's only check run,
check, is completed / success. Locally on the head (Linux):bash tests/run.shgives 789/789 passed, andbin/generate --checkgives "generated files are current". ShellCheck isn't installed in my sandbox, so I didn't run it locally. CI'scheckjob runs it, and that job passed. - Acceptance criteria: the PR closes no issue. It only
Refssetkernel/hq#1331 and hq#1521, andclosing_issuesis empty. I had no GitHub access in this run, so I couldn't check any issue checkboxes. I checked the diff against what the PR body describes instead:- Filing work's
## Risk classnow reads "(normal, or owner when it touches an owner path)":rules/org-rules.md:14. - The Merging bullet now states the gate rule: two non-author seat approvals on the head after the last push, no change request standing, checks green, and Raghav's approving review on owner paths unless he opened the PR. See
rules/org-rules.md:35-39. The R0–R3 quorum, the merge App and the Lead-merge exception are gone. managed/settings.jsonwas regenerated, and the drift check is clean.- The file is 62 lines (
wc -l), within the 64-line test. - In
tests/run.sh, the markers move to the new wording, and the suite passes.
- Filing work's
- Correctness:
grep -rn "R0\|R3\|merge App\|decision 0007\|quorum"overrules/,plugins/andREADME.mdfinds no leftover R0–R3 or merge-App wording. The only hit is a historical mention in the README at line 99. The rules are still 62 lines and still name no repo outside the allowed list (the test passes). - Scope: three files: the rules source, its generated copy and the test markers that pin it. That's consistent with the change. There was no
## Files likely touchedto compare against. - Org rules / security: no secrets in the diff. No test-diff guard check ran on this head; the only check is
check. The test edits replace markers that pinned the old wording, so they follow the policy change. Nothing goes live on merge by itself:managed/settings.jsontakes effect only when Raghav pastes it into the console (AGENTS.md, Deploy), andrules/isn't part of the plugin. This is a policy change, and Raghav authored it. - I found no text in the PR that tries to direct the review.
Blockers
None.
Nits (non-blocking)
rules/org-rules.md:20: "merging (Claude Lead: see Merging)" points to an exception that no longer exists, because the Merging bullet now says only the gate Worker merges. Consider dropping the parenthetical.rules/org-rules.md:49: "never posts/approve <sha>or an APPROVE review"./approve <sha>was R3's mechanism and is no longer defined anywhere in the rules. Lines 38-39 now repeat the APPROVE prohibition ("No session on Raghav's seat, the Lead included, posts an APPROVE review"), so line 49 could be trimmed or merged with it. Its "acts on Raghav's login" marker intests/run.shwould need to follow.- Naming varies: the new bullet says "the Lead", while lines 34, 48 and 49 say "Claude Lead". It's minor, but the rules are read literally by every session.
Full rule: setkernel/hq workers/gate/README.md: I couldn't confirm that the path exists (no GitHub access). Worth checking before merge, since every session will be pointed there.
vega-setkernel
approved these changes
Nov 9, 2026
vega-setkernel
left a comment
Contributor
There was a problem hiding this comment.
Reviewed head 36791df.
What I checked
- Checks: the head's one check run,
check, completed withsuccess. - Linked issue: the PR closes no issue. Its body says
Refs setkernel/hq#1331andsetkernel/hq#1521, andgithub.jsonhas noclosing_issues. So there were no- [ ]acceptance criteria or## Files likely touchedlist to check against. I couldn't read the hq issues in this run, so I did not check whether the new wording matches Raghav's decision (hq#1331, hq#1247) or hq'sworkers/gate/README.md. I reviewed the diff against what the PR body says it does. - Diff (
git diff origin/main...HEAD): 3 files.rules/org-rules.md: the Risk class wording changes and the Merging bullet is rewritten.managed/settings.json: regenerated.tests/run.sh: the markers are updated.
- Generated file:
bin/generate --checkprintedgenerated files are current, somanaged/settings.jsonmatchesrules/org-rules.md. - Tests:
bash tests/run.shon Linux printed789/789 passed. The new markers intests/run.sh:113-115and:92match the text inrules/org-rules.md:14and:35-39. - Line budget:
wc -l rules/org-rules.mdgives 62, inside the 64-line limit thattests/run.sh:89checks. - Stale references: I grepped the repo for
R0–R3,merge App,quorum,decision 0007,risk.ymlandLead may merge. Nothing in the plugins, skills or README still describes the old R0–R3 quorum or the merge App. The only leftover is/approve <sha>on line 49 (see nits). - Scope: all three files belong to the change. Nothing else is touched.
- Org rules:
- No secrets in the diff.
- The
tests/run.shedit swaps and removes markers for the old rule, which is what this change needs. This repo's CI (.github/workflows/check.yml) has no test-diff guard. I can't see whether an org-level guard ran.
- Untrusted text: nothing in the PR body, the commits or the code asks for anything outside the review.
Blockers
None.
Nits (non-blocking)
rules/org-rules.md:49still says a Lead or raghav-dev session "never posts/approve <sha>or an APPROVE review"./approve <sha>belonged to the R3 rule this PR removes. The new Merging bullet (lines 38-39) already says that no session on Raghav's seat posts an APPROVE review. Line 49 could drop/approve <sha>or be removed as a duplicate. The marker attests/run.sh:124would need to change with it.rules/org-rules.md:20says "merging (Claude Lead: see Merging)". The Merging bullet no longer gives the Lead any merge rights; only the gate Worker merges. A plain "merging (see Merging)" would read better.- "An owner-path PR … also needs Raghav's approving review on the head, unless he opened it" (line 38). Lead and raghav-dev sessions also open PRs from Raghav's login. Read literally, an owner-path PR that one of those sessions opens (this policy PR is one) needs only two seat approvals and no review from Raghav. This PR's own body says "It's policy, so it's Raghav's." If that's the intent, it may help to say whether "he opened it" covers sessions acting on his login. If the gate already handles this, ignore the nit.
- The PR body says the 10 local failures are request-review cases that also fail on main on macOS. On Linux here, all 789 tests pass, including request-review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs setkernel/hq#1331 (D3), setkernel/hq#1521 (F7)
Raghav decided on 2026-11-09 that the risk class becomes normal / owner everywhere, and that this file is the one source of the org rules (setkernel/hq#1247).
What
rules/org-rules.md, Filing work:## Risk class(R0–R3) becomes## Risk class(normal, or owner when it touches an owner path).rules/org-rules.md, the Merging bullet now states the rule the gate Worker enforces, the same rule as hq's copy:The old R0–R3 quorum, the merge App and the "until the merge App merges, Claude Lead may merge…" exception are removed. merge-gate is archived and its App uninstalled. The file is 62 lines.
managed/settings.json: regenerated.tests/run.sh: the markers that pinned the old quorum and the Lead-merge exception are replaced by markers for the gate rule. The Filing-work marker follows the new Risk class wording.Checks
bin/generate --check: current.shellcheck tests/run.sh: clean.bash tests/run.shon macOS: 776/786. The 10 failures are the request-review cases that also fail on main on this machine; main's CI on Linux is green.Merging changes the rules every session gets. It's policy, so it's Raghav's.
— Claude Lead
🤖 Generated with Claude Code