Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion plugins/setkernel/agents/reviewer.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ the code before reporting it; drop anything you cannot substantiate. For each bl
- why it is wrong (input → wrong result);
- how to show it fails (a command, an input, a test), and the smallest fix.

Run the repo's checks (see "Commands" in `AGENTS.md`) and report their exact result lines. Stay
CI is already green on the PR, so rerun only the checks that confirm or rule out a finding:
`make check-diff` if the repo has that target, else the checks under "Commands" in `AGENTS.md`. Report
their exact result lines; a step `make check-diff` did not pick is "not selected", never "passed". Stay
read-only: `git`, reads and the checks only; never edit files. If there are no blockers, say
"No blockers" and list at most three non-blocking notes. End with "merge", "merge after fixes" or
"don't merge".
15 changes: 10 additions & 5 deletions plugins/setkernel/skills/verify/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,16 @@ that tree, with its exact result.

## Find the checks

0. If the repo root has a `check` target (the first of `GNUmakefile`, `makefile`, `Makefile` that
exists, with a line matching `^check[[:space:]]*:`), run `make check` and use it instead of
reading the workflows and running steps yourself: it runs every check CI runs. Report its
per-step PASS/FAIL lines and its final count. Without a `check` target, use steps 1–2.
Steps 3 and 4 apply either way: run the setup step before `make check`.
0. If the repo root has a `check-diff` target (the first of `GNUmakefile`, `makefile`, `Makefile`
that exists, with a line matching `^check-diff[[:space:]]*:`), commit the work first, then run
`make check-diff`: it picks the steps the committed diff against the default branch needs.
Report its per-step PASS/FAIL lines and its final count; a step it did not pick is
"not selected", never "passed". Run the full `make check` only when you are asked to; CI runs
it on the default branch. Otherwise, if the repo root has a `check` target (a line matching
`^check[[:space:]]*:`), run `make check` and use it instead of reading the workflows and running
steps yourself: it runs every check CI runs. Report its per-step PASS/FAIL lines and its final
count. With neither target, use steps 1–2.
Steps 3 and 4 apply either way: run the setup step before `make check-diff` or `make check`.
1. Read the "Commands" section of the root `AGENTS.md` (and any area `AGENTS.md` for the files you
touched), then the CI workflow(s) in `.github/workflows/`.
2. While iterating, run the smallest set of checks that can catch what the change could break.
Expand Down
8 changes: 8 additions & 0 deletions tests/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -1022,6 +1022,14 @@ skill=$root/plugins/setkernel/skills/verify/SKILL.md
expect 0 "run \`make check\`" "the verify skill runs make check when the repo has the target" -- grep -F 'run `make check`' "$skill"
expect 0 "needs Docker (or OrbStack)" "the verify skill reports a Docker-less run as not run" -- grep -F 'needs Docker (or OrbStack)' "$skill"
expect 0 "Steps 3 and 4 apply either way" "the verify skill keeps the grep and setup steps with a check target" -- grep -F 'Steps 3 and 4 apply either way' "$skill"
# It prefers `make check-diff` where a repo has it: committed work first, unpicked steps "not selected".
expect 0 "make check-diff" "the verify skill runs make check-diff when the repo has the target" -- grep -F 'make check-diff' "$skill"
expect 0 "commit the work first" "the verify skill commits before make check-diff" -- grep -F 'commit the work first' "$skill"
expect 0 "not selected" "the verify skill reports unpicked steps as not selected" -- grep -F 'not selected' "$skill"
expect 1 "" "the verify skill names no model, CLI or vendor" -- grep -iE 'claude|codex|anthropic|openai' "$skill"
expect 0 "make check-diff" "the reviewer reruns make check-diff where the repo has it" -- grep -F 'make check-diff' "$root/plugins/setkernel/agents/reviewer.md"
expect 0 "^none unlisted$" "the verify skill names no setkernel repo outside the allowed list" -- unlisted_repos "$root/plugins/setkernel/skills/verify"
expect 0 "^none unlisted$" "the agents name no setkernel repo outside the allowed list" -- unlisted_repos "$root/plugins/setkernel/agents"

# The request-review skill (#63): a stub gh with a made-up team; state files say what GitHub does.
rr=$root/plugins/setkernel/skills/request-review/request-review.sh
Expand Down
Loading