Repository navigation
docs(rules): judge work by its output; a test only where logic can silently break - #65
Merged
Merged
Conversation
…lently break Raghav, 2026-11-03: work is for an output, and tests prove it works. They are not the output. The old line "new behaviour needs a test", with the reviewer blocking on missing tests, made almost every PR add a test file and a check step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for Raghav's review. This changes org policy, so Raghav merges it.
Why
The work is done for an output. Tests are there to show it works as it should; they are not the goal. A process that makes nearly every PR add a test file and a check step is feeding itself.
Over the last week, more lines of tests and check steps were added than lines of everything else. Three rules drove it:
What changes
rules/org-rules.md: "new behaviour needs a test" becomes:plugins/setkernel/agents/reviewer.md:managed/settings.json: regenerated withbin/generate.Unchanged: the test-diff guard and its allow lines.
After merge
Raghav pastes
managed/settings.jsoninto the org's managed settings. The reviewer change reaches seats through plugin auto-update.Checks
bash tests/run.sh: "795/795 passed".🤖 Generated with Claude Code