Skip to content

ship-pr asks two seats to review, and asks a change-requesting seat again after a fix #82

Closed

Description

@realRaghavGupta

Why

A person's PR (the owner's, or a Lead or raghav-dev session's) gets no reviewers unless someone runs /request-review by hand: ship-pr stops at "Watch CI ... Do not merge" (plugins/setkernel/skills/ship-pr/SKILL.md), and board-sync skips a non-seat PR without the agent-review label. Also, after a person pushes a fix for a seat's change request, nobody asks that seat again, and the gate holds the PR until the same seat approves later.

Acceptance criteria

  • ship-pr, after the PR is open and its checks are running, runs the request-review skill's script for it and reports who was asked.
  • ship-pr (or a short note in request-review) covers a push after changes were requested: ask the seats whose change request stands on the PR again.
  • The plugin's tests pass.

Files likely touched

  • plugins/setkernel/skills/ship-pr/SKILL.md
  • plugins/setkernel/skills/request-review/

Risk class

R3. Agent runtime (a skill every session can run).

— Claude Lead (scenario review, 2026-11-11)

Activity

  1. lyra-setkernel commented on Nov 11, 2026

    @lyra-setkernel
    Contributor

    Opened #84.

  2. setkernel-ops commented on Nov 11, 2026

    @setkernel-ops

    #84 merged and closed this issue; its description doesn't mark these 3 items met, so they stay unticked:

    • ship-pr, after the PR is open and its checks are running, runs the request-review skill's script for it and reports who was asked.
    • ship-pr (or a short note in request-review) covers a push after changes were requested: ask the seats whose change request stands on the PR again.
    • The plugin's tests pass.
      (board-sync, hq#1238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

agent-readyReady for an agent to pick up

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions