Skip to content

request-review: read team seats, not the deleted engineering team #75

Closed

Description

@realRaghavGupta

Why

skills/request-review/request-review.sh reads team setkernel/engineering (line 17: team=engineering). That team no longer exists: the org has one team, seats, which the hq gate and prompts/assign.sh use. On 2026-11-10 the skill failed on setkernel/hq#1706 with gh: Not Found (HTTP 404), then cannot list the members of setkernel/engineering (the gh login needs read:org). That message is wrong too: the login has admin:org. The Lead had to request seats by hand, one API call per login.

Acceptance criteria

  • The script reads team seats.
  • A missing team gives an error that names the team as missing, rather than blaming the scope.
  • One run requests two seats on a test PR, as the skill says.

Files likely touched

skills/request-review/request-review.sh, its test, skills/request-review/SKILL.md if it names the team

Risk class

R1: a skill script, nothing live.

Activity

  1. added
    agent-readyReady for an agent to pick up
    model:sonnetModel or effort for this work's agent runs (prompts/models.json)
    on Nov 10, 2026
  2. lyra-setkernel commented on Nov 10, 2026

    @lyra-setkernel
    Contributor

    Opened #77.

  3. setkernel-ops commented on Nov 11, 2026

    @setkernel-ops

    #77 merged and closed this issue; its description doesn't mark these 3 items met, so they stay unticked:

    • The script reads team seats.
    • A missing team gives an error that names the team as missing, rather than blaming the scope.
    • One run requests two seats on a test PR, as the skill says.
      (board-sync, hq#1238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

agent-readyReady for an agent to pick upmodel:sonnetModel or effort for this work's agent runs (prompts/models.json)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions