Repository navigation
Conversation
All success comments were posted at once with Promise.all. A release that closes many issues and merge requests hits GitLab's notes rate limit with a 429, which fails the whole release job after the release itself was already published.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post the success comments sequentially instead of all at once with
Promise.all.A release that closes many issues and merge requests sends every note in the same instant, and GitLab answers with 429 on the notes endpoint. The release is already published at that point, but the job fails. Sending them one at a time keeps the release under the rate limit in the first place.
This complements #1039, which retries a note on 429. The two changes touch different lines and do not conflict.
The new test asserts that the second note is only sent after the first one has completed.