Repository navigation
fix: recover provider requirements and unify device details - #751
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nuki’s supported-device rows show “Requirement message not found” instead of their SmartHosting subscription requirement. The inherited Strapi translator treats provider requirement prose as a dictionary key; the existing public Ecosystem provider record still contains the correct text. A catalog audit found the same issue on eight providers.
Recover missing provider requirement messages from the matching provider’s
requirements_md, fetching only affected provider slugs after embed/provider scoping. Preserve conditional support and show a safe setup warning if metadata is unavailable. Add an exact same-originproviders/listrewrite so hosted embeds retain the Chrome network fix.Each row now labels its Supported capabilities and has one “Model and requirements details” disclosure. Capability warning buttons and the keyboard-accessible summary toggle that same panel, containing contextual requirement icons, affected capabilities, model numbers, and integration details.
Validation: 78 tests pass; TypeScript, lint, library/example builds, and bundle budget pass (67.92 kB gzip / 80 kB). Chrome 149 checks on the actual Nuki, August, and KeyInCode docs pages with the local build and real Ecosystem data pass for light/dark theme changes, mobile width, warning/summary keyboard controls, synchronized expanded states, and iframe resize. Deployed preview
react-4q9g6rkko.seam.vcpassed those same Chrome checks against real data, with all same-origin API responses returning 200, including scopedproviders/list?slugs=nuki-web. A deliberate provider-request failure retained all six Nuki models, conditional warnings, bridge/keypad constraints, and a working shared disclosure without the placeholder. The updated display logic also passed an audit across all 1,040 public models and 87 providers with no remaining displayed placeholders.Fixes DEVDB-465
https://linear.app/seam/issue/DEVDB-465/resolve-nuki-requirement-placeholder-and-combine-device