Skip to content

fix: clarify device compatibility and match the docs theme - #750

Merged
sybohy merged 2 commits into
mainfrom
fix/devicedb-dark-embed
Oct 27, 2026
Merged

sybohy merged 2 commits into
mainfrom
fix/devicedb-dark-embed

Conversation

@sybohy

@sybohy sybohy commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

The supported-device embed mixes dark rows with a white document canvas and low-contrast logos. Device rows are also hard to scan: identifiers crowd the name, feature badges jump to a separate column, and generic compatibility prose repeats the same accessory requirements.

Match the hosted document’s color scheme to the docs theme and use a white tile for manufacturer logos, since monochrome catalog assets are not necessarily dark-mode variants. Present device name/type, a consistent feature list with support icons, and grouped requirement notes with bridge/keypad icons and affected features. Move all model identifiers/provider information into keyboard-accessible Model details while keeping it searchable. Suppress known boilerplate while preserving specific constraints and conditional/beta support. Remove the duplicate catalog footer inside iframes; standalone visits retain it and docs retain their existing fallback link.

Validation:

  • All 75 tests, typecheck, lint, library/examples builds, and bundle-size check pass (Ecosystem 67.18 kB gzip, budget 80 kB).
  • Built embed tested inside real August and KeyInCode production guides using real Ecosystem data: 7/13 devices, dark→light→dark with light OS preference, no white canvas, readable logo, 390px layout without overflow, keyboard details disclosure, and grouped requirements without generic repeated text.
  • Added regression coverage for hidden identifiers and requirement extraction that retains specific constraints while removing boilerplate/cycles.
  • Reviewed original custom-device-db-web support/requirement UI for visual patterns. No Strapi, backend/data, or docs source changes.
  • Deployed preview react-olh6xwmp7.seam.vc (head 9d89911) verified in Chrome 149: actual docs theme menu, dark→light→dark, desktop/390px screenshots, exact requirement grouping, hidden model identifiers, keyboard disclosure, no duplicate footer; standalone auto theme follows system preference. Real Ecosystem data, no mocked API responses or disabled browser security. All checks green. Production 5.2.2 is deployed; repeated all browser checks on unchanged live August and KeyInCode guides with the actual docs theme menu, desktop/mobile layouts and standalone auto theme. No page errors. All release checks green after retrying one unrelated fake-server port collision.

Fixes DEVDB-464.

@sybohy
sybohy requested review from dawnho and razor-x as code owners October 27, 2026 05:11
@sybohy
sybohy merged commit 3febd67 into main Oct 27, 2026
13 checks passed
@sybohy
sybohy deleted the fix/devicedb-dark-embed branch October 27, 2026 05:19

This branch was successfully deployed

1 active deployment
Preview — 9d899117 Deployed Oct 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant