Repository navigation
feat: add provider-scoped Ecosystem device embeds for docs - #748
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brand-guide supported-device embeds currently fail because the legacy Strapi embed token rejects the docs origin. This adds a native React replacement to the existing Ecosystem-backed SupportedDevices component.
/examples/supported-devices/, using public Ecosystem reads without Strapi or an embed key. Accept manufacturer/provider/device type/capability/theme query parameters.Validation: lint, typecheck, all 73 tests, library build, examples build, docs/Storybook build and bundle-size check pass locally. Ecosystem bundle: 66.48 kB gzip (80 kB budget). Browser checks passed against production Ecosystem data: August (7 locks), KeyInCode (13), Oracode (5) and First Alert (12). Verified mobile rendering, dark/light themes, iframe resizing, client navigation cleanup, wrong-origin message rejection, API outage/Retry recovery and Ring's empty state. Preview headers were verified for both canonical and trailing-slash URLs; other example pages retain SAMEORIGIN. The pre-existing parent August guide React #418 warning remains; the isolated embed renders correctly.
Rollout: merge/deploy this PR before docs #1478. No automatic merge.
Fixes DEVDB-459
Fixes DEVDB-460
Refs DEVDB-462
Project