Skip to content

Fix sbx login and start sandboxd up front in the Go upgrade workflow - #595

Merged
mathieu-benoit merged 1 commit into
mainfrom
fix-upgrade-go-sbx-login
Nov 18, 2026
Merged

mathieu-benoit merged 1 commit into
mainfrom
fix-upgrade-go-sbx-login

Conversation

@mathieu-benoit

Copy link
Copy Markdown
Contributor

Description

Fixes the first run of the upgrade-go-version workflow after #594 (run 44218970968), which failed at sbx login with --password-stdin requires --username.

  • Read DOCKER_HUB_USERNAME from secrets (it's a repository secret, not a variable), and fail with an explicit error if DOCKER_HUB_USERNAME or DOCKER_HUB_TOKEN is empty.
  • Start sandboxd right after installing sbx: sbx daemon start --detach --policy deny-all, then sbx daemon status. This replaces the later sbx policy init deny-all. In the failed run, sbx diagnose reported "Daemon — not reachable" only because nothing had started the daemon yet (login failed on argument checking first); now a daemon problem fails in its own step.
  • Diagnostics on failure also collect sandboxd's *.log files from ~/.local/state/sandboxes into the sbx-debug artifact.

What does this PR do?

Gets the workflow past sbx login. The run also confirmed /dev/kvm is accessible on ubuntu-latest with the udev rule. Not verified yet: anything after login (kit build, sandbox create, upgrade steps); sbx daemon start --detach --policy deny-all was checked against sbx v0.54.0 help only, not run on a runner.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

AI usage disclosure:

  • AI was used
    • I understand every change.
    • Briefly describe how AI was used: This PR was written in part with the assistance of generative AI (Claude Code), which read the failed run's logs and drafted the fix.

🤖 Generated with Claude Code

DOCKER_HUB_USERNAME is a repository secret, not a variable, so read it
from secrets. The first run failed with "--password-stdin requires
--username" because the variable was empty, and now fails with an
explicit error if either secret is missing.

Start sandboxd right after installing sbx, with the deny-all global
policy, so a daemon problem fails in that step. In the failed run the
"Daemon - not reachable" diagnostic only meant nothing had started the
daemon yet. Also collect sandboxd's log files in the sbx-debug artifact.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
@mathieu-benoit
mathieu-benoit marked this pull request as ready for review November 18, 2026 01:56
@github-actions

Copy link
Copy Markdown
Contributor

Overview

Image reference score-compose:latest score-compose:latest
- digest 1d988d6a2642 2b4598b01c56
- tag latest latest
- provenance b789df2 f151add
- vulnerabilities critical: 0 high: 0 medium: 0 low: 0 critical: 0 high: 0 medium: 0 low: 0
- platform linux/amd64 linux/amd64
- size 7.2 MB 7.2 MB (-14 B)
- packages 53 53
Base Image static:20261020-alpine3.24 static:20261020-alpine3.24
- vulnerabilities
Policies (0 improved, 0 worsened)

Health score: score-compose:latest B (83%) → score-compose:latest B (83%)

Policy Name score-compose:latest score-compose:latest Change Standing
Default non-root user ✅ ✅ No Change
No copyleft licenses ⚠️ 2 ⚠️ 2 No Change
No fixable critical or high vulnerabilities ✅ ✅ No Change
No high-profile vulnerabilities ✅ ✅ No Change
No outdated base images ⚠️ ⚠️ No Change
No unapproved base images ✅ ✅ No Change
Supply chain attestations ✅ ✅ No Change
Packages and Vulnerabilities (1 package changes and 0 vulnerability changes)
  • ♾️ 1 packages changed
  • 52 packages unchanged
Changes for packages of type golang (1 changes)
Package Version
score-compose:latest
Version
score-compose:latest
♾️ github.com/score-spec/score-compose 0.0.0-20261118014929-b789df23bb1d+dirty 0.0.0-20261118015541-f151add80957+dirty

@mathieu-benoit
mathieu-benoit merged commit f264cc7 into main Nov 18, 2026
18 of 19 checks passed
@mathieu-benoit
mathieu-benoit deleted the fix-upgrade-go-sbx-login branch November 18, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant