Repository navigation
Fix sbx login and start sandboxd up front in the Go upgrade workflow - #595
Merged
Merged
Conversation
DOCKER_HUB_USERNAME is a repository secret, not a variable, so read it from secrets. The first run failed with "--password-stdin requires --username" because the variable was empty, and now fails with an explicit error if either secret is missing. Start sandboxd right after installing sbx, with the deny-all global policy, so a daemon problem fails in that step. In the failed run the "Daemon - not reachable" diagnostic only meant nothing had started the daemon yet. Also collect sandboxd's log files in the sbx-debug artifact. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
mathieu-benoit
marked this pull request as ready for review
November 18, 2026 01:56
Contributor
Overview
Policies (0 improved, 0 worsened)Health score:
Packages and Vulnerabilities (1 package changes and 0 vulnerability changes)
Changes for packages of type
|
| Package | Versionscore-compose:latest |
Versionscore-compose:latest |
|
|---|---|---|---|
| ♾️ | github.com/score-spec/score-compose | 0.0.0-20261118014929-b789df23bb1d+dirty |
0.0.0-20261118015541-f151add80957+dirty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the first run of the
upgrade-go-versionworkflow after #594 (run 44218970968), which failed atsbx loginwith--password-stdin requires --username.DOCKER_HUB_USERNAMEfromsecrets(it's a repository secret, not a variable), and fail with an explicit error ifDOCKER_HUB_USERNAMEorDOCKER_HUB_TOKENis empty.sbx daemon start --detach --policy deny-all, thensbx daemon status. This replaces the latersbx policy init deny-all. In the failed run,sbx diagnosereported "Daemon — not reachable" only because nothing had started the daemon yet (login failed on argument checking first); now a daemon problem fails in its own step.*.logfiles from~/.local/state/sandboxesinto thesbx-debugartifact.What does this PR do?
Gets the workflow past
sbx login. The run also confirmed/dev/kvm is accessibleonubuntu-latestwith the udev rule. Not verified yet: anything after login (kit build, sandbox create, upgrade steps);sbx daemon start --detach --policy deny-allwas checked againstsbxv0.54.0 help only, not run on a runner.Types of changes
Checklist:
AI usage disclosure:
🤖 Generated with Claude Code