Repository navigation
Move tempfile to dev-dependencies and drop clap_derive - #143
Merged
Merged
Conversation
tempfile is only used by tests, but as a normal dependency it reached every crate that depends on codeowners, along with rustix, linux-raw-sys, getrandom, wasip2, wit-bindgen, errno, fastrand and r-efi. The code_ownership gem vendors that tree into its source gem, so it shipped all nine crates. Three of them carry an Apache-2.0 WITH LLVM-exception license file, which license scanners such as Socket flag even though each crate is also offered under MIT. clap_derive was a direct dependency that nothing names. clap's derive feature already depends on it, so removing it changes only Cargo.lock's list of codeowners' direct dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tempfileto[dev-dependencies]. Only the unit tests insrc/and the tests intests/use it, but as a normal dependency it reached every crate that depends oncodeowners. So did eight crates that only it pulls in: rustix, linux-raw-sys, getrandom, wasip2, wit-bindgen, errno, fastrand and r-efi.cargo vendorinto its source gem and so ships all nine crates' sources. Three of them, rustix, linux-raw-sys and wit-bindgen, include aLICENSE-Apache-2.0_WITH_LLVM-exceptionfile. License scanners such as Socket flag that file even though each crate is also offered under MIT.clap_derive. It was a direct dependency that nothing names, andclap'sderivefeature already depends on it, so the only change it makes is one line inCargo.lock.Verification
--locked, all of these pass:cargo check,cargo build --release,cargo fmt --all -- --check,cargo clippy --all-targets --all-features -- -D warningsandcargo test. The tests report 178 passed and 3 ignored.[dependencies]entry to[dev-dependencies]in turn and rancargo check --lib --bins. Every other dependency is needed by the library or binary.clap_derivewas the only entry that also compiled with--all-targetswhen removed outright.cargo vendorgoes from 120 crates to 111. It loses exactly the nine above and adds none.unicode-identstays, with its Unicode-3.0 license file, becauseproc-macro2needs it for derive macros.