Repository navigation
Bump prism to 1.9.0 in the rubocop benchmark to fix CI - #563
Merged
Merged
Conversation
prism 1.4.0 fails to compile its native extension on non-CRuby engines with GCC 15, as found on the ubuntu-26.04 runner image that ubuntu-latest is migrating to. On those engines prism's extconf.rb builds libprism via the gem's own Makefile, which uses -Werror, and GCC 15 reports: src/util/pm_string.c:186:17: error: storing the address of local variable 'source' in '*string.source' [-Werror=dangling-pointer=] prism 1.6.0 fixed this by using a static empty_source array, so use the latest prism release. rubocop stays at 1.79.1 so the workload is unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
k0kubun
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/truffleruby/truffleruby/actions/runs/40510552782/job/122211001277#step:1:17
which failed with:
Which was trigger by ubuntu-latest becoming 26.04.
Surprisingly the corresponding job on this repo also uses ubuntu-latest but was run on 24.04:
https://github.com/ruby/ruby-bench/actions/runs/40529770004/job/122279069041#step:1:17
prism 1.4.0 fails to compile its native extension on non-CRuby engines with GCC 15, as found on the ubuntu-26.04 runner image that ubuntu-latest is migrating to. On those engines prism's extconf.rb builds libprism via the gem's own Makefile, which uses -Werror, and GCC 15 reports:
prism 1.6.0 fixed this by using a static empty_source array, so use the latest prism release. rubocop stays at 1.79.1 so the workload is unchanged.