Repository navigation
test: add health, last_verified_at, credentials_expire_at and account_label to the connection fixture - #106
Merged
Conversation
…_label to the connection fixture
sahil-roe
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release
1-1-6adds four read-only fields to theConnectionschema:health,last_verified_at,credentials_expire_atandaccount_label. Read-only fields are marked required in the OpenAPI spec, so the regeneratedConnection.from_dictreads each one with no default.The hand-written
_connection_json()fixture intests/unit/test_connections_wrapper_transport.pyhad none of them, so three wrapper transport tests fail withKeyError: 'health'on the release PR (#104):test_connection_create_keeps_org_id_in_body_and_querytest_connection_update_keeps_org_id_out_of_patch_bodytest_connection_replace_keeps_org_id_out_of_put_bodyThis PR adds the four keys to the fixture. It is a test-only change to one file.
It targets
mainrather than the release branch because the release workflow rebuildsrelease-sdk-python-*frommainon every run. The extra keys are harmless on the current generated model, so this can merge ahead of the release PR. Same kind of fix as #84.Test Plan
uv run pyteston this branch (currentmainmodel): 68 passeduv run pytestonrelease-sdk-python-1-1-6(2bee7a5) with this fixture dropped in: 68 passed, including the three tests that fail in CI on Release v1.1.24 #104ruff checkandruff format --checkon the changed file: cleanSelf-review: one file, four added lines, no findings.
After merge
Re-run the Python
update-sdkjob in the roe-main release workflow forrelease-1-1-6so #104 is rebuilt frommainand itstestjob goes green.🤖 Generated with Claude Code