Repository navigation
Conversation
An XML declaration with no whitespace between the encoding declaration
and the standalone declaration was accepted, e.g.:
<?xml version="1.0" encoding="UTF-8"standalone="yes"?>
`SDDecl` starts with a mandatory `S`, just as `EncodingDecl` does. The
whitespace before `encoding` was already required. The whitespace before
`standalone` is now required as well when an encoding precedes it.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Owner
|
Thanks for bringing this issue to my attention! While the fix here does address the narrow case you described, I realized while reviewing this that a more comprehensive fix was needed to cover additional cases, and that there was a similar issue related to missing whitespace before a doctype's system identifier. Because of that, I decided to treat this PR as a bug report and implemented the fix using a slightly different approach, which you can see in bdfa328. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An XML declaration with no whitespace between the encoding and
standaloneis currently accepted:SDDeclstarts with a mandatoryS, i.e. whitespace (production 32), the same wayEncodingDecldoes. The whitespace beforeencodingis already enforced (version="1.0"encoding=…throws). The one beforestandaloneisn’t checked when an encoding precedes it.This change only looks for
standaloneif whitespace was consumed after the encoding. It adds one regression test, and coverage stays at 100%.I left the changelog untouched, as the previous fixes did. Happy to add an entry if preferred.
🤖 Generated with Claude Code