Repository navigation
GH-93: show only the name and build on the splash - #94
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #93
What changed
The startup splash now shows only the app name and the build version:
Removed the
[account] connecting to host...line and thepress any key to skipinstruction, along with the now-unused
splashConnectinghelper.Any key still dismisses the splash (and is consumed, so
qskips rather than quits);only the on-screen messaging is gone.
Tests
tui/splash_test.go:TestSplashShowsOnlyNameAndBuild— exactly two content lines,chuteandv9.9.9.TestSplashShowsDevWhenTheBuildHasNoVersion— an unversioned build rendersdev.m.splashrather than a string that no longer exists.
Verification
gofmt -l .empty,go vet ./...clean,go test -count=1 ./...and-racepass;coverage tui 91.2 (floor 89.1) / config 91.0 / mail 87.4 / main 38.8;
golangci-lint v2.15.00 issues.