Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions specs/002-analysis-report/research.md
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,16 @@ WebsiteAngular task that gates the report, done before the figures are timed (pl
Order of work, step 0), with a test there that fails when the page is ready before its overlay;
the report's checks also look for each figure's overlay (quickstart §3). Once settled, the overview is as today's, and a pathway's figure
differs where the report's resource is not the result's default.
**Settled (13 Nov 2026, T017).** The race above is closed in WebsiteAngular. Its render page has
waited for the overlay since reactome/WebsiteAngular#771 (2 Nov, after this was written): ready only
once the analysis has settled on the result's default resource and the view shows it (a
diagram coloured for that token and resource, an illustration coloured with the current
result, the overview showing the tree for that token and resource; the reaction layout is
never coloured), and a token that cannot be read ends in the page's error. Its cache key
was bumped with it, and every figure cached since was drawn with the wait.
reactome/WebsiteAngular#958 added the same tests for a page held between figures (its spec
018), each seen failing on a mutant.

Adding `resource` is a WebsiteAngular task; until it ships, that is a listed difference
(spec, FR-204).

Expand Down
4 changes: 3 additions & 1 deletion specs/002-analysis-report/tasks.md
Original file line number Diff line number Diff line change
Expand Up @@ -433,11 +433,13 @@ status and file name as recorded or a listed difference (SC-202).
**Purpose:** the report on real data, against today's, and the website routed to it.
The comparisons run on the development host's own services only.

- [ ] T017 [WA] The render page waits for its analysis overlay (plan, Order of work,
- [x] T017 [WA] The render page waits for its analysis overlay (plan, Order of work,
step 0; research R3; FR-204), in WebsiteAngular, under its render service's spec:
readiness waits for the overlay for the result's default resource, with a test that
fails when the page is ready before it; the render cache's key bumped, so figures
cached without it are not served. Gates T019 and T020; link its PR here.
- **Done:** reactome/WebsiteAngular#771 (the wait and its cache key, 2 Nov) and
reactome/WebsiteAngular#958 (the same for held pages); research R3, "Settled".

- [ ] T018 [WA] The pdf-export image's pin and settings for the report (WebsiteAngular's
`deploy/pdf-export` and compose): the report's analysis setting and the working
Expand Down
Loading