[adamjohnwright]

Spec: 018-render-page-reuse, T013 (added and ticked here). This is pdf-export's spec 002 T017 (its plan, Order of work, step 0; research R3; FR-204), which gates its T019 and T020.

What T017 asks, and what was already there

T017 asks that, with a token, the render page be ready only once the figure carries the overlay for the result's default resource. A token that cannot be read should end in the page's error. The render cache's key should be bumped, and a test should fail when the page is ready first.

#771 (2 Nov) already built this, before held pages existed. pdf-export's R3 was written on 30 Oct, before #771.

• The wait: analysisShown waits on AnalysisService.settled and on each view's own colouring: the diagram's appliedAnalysis, the illustration's applied result, and the overview's current tree.
• Unreadable tokens: analysisFailure turns them into an error.
• The cache key went to v12 for it.
• Tests: the fresh-page tests in e2e/downloads.spec.ts.

What this adds

Held pages (T005, #957) move to the next figure in the same app. The analysis service there may already have settled for the last figure, and no test covered a token there. New tests in e2e/downloads.spec.ts, each reading readiness on the moved figure's own host (data-render-nav):

• a diagram with a token, after an illustration without one;
• the genome-wide overview, after a diagram with the same token (the result is already settled);
• a dead token (410) after a figure that drew, which must end in the error and not be ready.

Each has its own recording. The analysis is the existing made-up token, answered in the test, with its UNIPROT loads held back.

Seen failing (constitution III)

Each mutant was built by a dev server of this tree and run against the recorded answers:

Mutant	Fails
analysisShown always true	all 5 overlay tests, fresh and held
only settled kept, no per-view check	4 (not the illustration's, which colours as its result arrives; noted in the test)
settled dropped	the illustration's
per-view checks skipped on a moved figure only	the 2 held tests alone
analysisFailure never fails	the 3 unreadable-token tests

The cache key is not bumped

No output changes here. Every figure cached under v12 or later was drawn with the wait, so a bump would only make the cache cold.

🤖 Generated with Claude Code