Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
RCTInspectorNetworkReporter.h declares reportRequestFailed:cancelled: with a BOOL parameter, but the implementation took bool. They're the same type on arm64, but on x86_64 macOS and Mac Catalyst BOOL is signed char, so the definition didn't match its declaration and clang warned with -Wmismatched-parameter-types. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 33ac4470-c1d2-43c0-92ee-8407909f0f6a
Saadnajmi
force-pushed
the
fix-inspector-network-reporter-bool
branch
from
October 15, 2026 21:35
58e104e to
2a93026
Compare
Saadnajmi
marked this pull request as ready for review
October 15, 2026 22:12
facebook-github-tools
Bot
added
the
Shared with Meta
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D125650488. |
|
@cortinico merged this pull request in 3e5a624. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
RCTInspectorNetworkReporter.hdeclares+reportRequestFailed:cancelled:with aBOOLparameter, but the implementation takesbool. They're the same type on arm64, but on x86_64 macOS and x86_64 Mac CatalystBOOLissigned char, so the definition doesn't match its declaration and clang warns with-Wmismatched-parameter-types.This makes the implementation take
BOOL, like the header.Changelog:
[IOS] [FIXED] - Fix the
cancelledparameter type ofRCTInspectorNetworkReporter'sreportRequestFailed:cancelled:to match its declarationTest Plan:
Made the same change in React Native macOS 0.81, which has the same mismatch, and built it for x86_64 macOS with warnings as errors:
-Wmismatched-parameter-typesno longer fires.